Skip to content

[CSP] Store static Cloudbeat configuration#4145

Merged
uri-weisman merged 9 commits intoelastic:mainfrom
uri-weisman:cloudbeat_cfg
Sep 11, 2022
Merged

[CSP] Store static Cloudbeat configuration#4145
uri-weisman merged 9 commits intoelastic:mainfrom
uri-weisman:cloudbeat_cfg

Conversation

@uri-weisman
Copy link
Contributor

@uri-weisman uri-weisman commented Sep 6, 2022 •
edited
Loading

What does this PR do?

Stores config file per supported benchmark to be propagated to Cloudbeat.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Should be tested with an agent image holding a cloudbeat binary from the following branch:

Related issues

Screenshots

@uri-weisman uri-weisman added the enhancement New feature or request label Sep 6, 2022
@uri-weisman uri-weisman mentioned this pull request Sep 7, 2022
Merged
@elasticmachine
Copy link

elasticmachine commented Sep 7, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-11T13:43:25.287+0000

  • Duration: 14 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 7, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.768
Classes 100.0% (0/0) 💚 2.768
Methods 25.0% (1/4) 👎 -64.586
Lines 100.0% (0/0) 💚 8.965
Conditionals 100.0% (0/0) 💚

@uri-weisman uri-weisman marked this pull request as ready for review September 7, 2022 14:51
@uri-weisman uri-weisman requested a review from a team as a code owner September 7, 2022 14:51
ofiriro3
ofiriro3 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ofiriro3 ofiriro3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done my friend looks good!

@JordanSh @orouz @CohenIdo

Please go over this PR, we are making changes to the integration to support the new Cloudbeat configuration format.
If you have any objections, please set this PR as Request changes

@uri-weisman Please don't merge this PR until one of them will approve

@orouz
Copy link
Contributor

orouz commented Sep 11, 2022

@uri-weisman

can we verify that installing this new integration still includes all relevant data (currently rules but now also fetchers?) in the agent policy?

orouz
orouz reviewed Sep 11, 2022
View reviewed changes
packages/cloud_security_posture/data_stream/findings/agent/stream/eks.yml.hbs
@@ -0,0 +1,36 @@
name: Findings
Copy link
Contributor

@orouz orouz Sep 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to add validation to these files (if there isn't any?)

my concern is that this yaml lives in an hbs file so linting is harder and formatting issues might be accidentally introduced, and if so, i think we'd know about it only when it reaches cloudbeat

@uri-weisman
Copy link
Contributor Author

uri-weisman commented Sep 11, 2022 •
edited
Loading

can we verify that installing this new integration still includes all relevant data (currently rules but now also fetchers?) in the agent policy?

@orouz - For an EKS integration

Screen Shot 2022-09-11 at 16 24 22

Screen Shot 2022-09-11 at 16 24 32

Vanillla Integration

Screen Shot 2022-09-11 at 16 29 57

Screen Shot 2022-09-11 at 16 30 12

orouz
orouz reviewed Sep 11, 2022
View reviewed changes
Copy link
Contributor

@orouz orouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uri-weisman uri-weisman merged commit da7bbee into elastic:main Sep 11, 2022
@uri-weisman uri-weisman deleted the cloudbeat_cfg branch September 11, 2022 13:59
@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orouz orouz orouz approved these changes

+1 more reviewer

@ofiriro3 ofiriro3 ofiriro3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@uri-weisman @elasticmachine @orouz @ofiriro3 @kfirpeled