[Cloud Posture] Remove runtime_cfg var by ofiriro3 · Pull Request #4496 · elastic/integrations

ofiriro3 · 2022-10-25T14:22:15Z

What does this PR do?

The following PR removes the usage of runtime_cfg and moves the configuration to be generated per kubernetes deployment using the hbs files

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Closes https://github.com/elastic/security-team/issues/4589

# Conflicts: # packages/cloud_security_posture/changelog.yml # packages/cloud_security_posture/manifest.yml

ofiriro3 · 2022-10-25T14:29:40Z

packages/cloud_security_posture/manifest.yml

  - security
 conditions:
-  kibana.version: "^8.5.0"
+  kibana.version: "^8.6.0"


@kfirpeled

I think this change is necessary here since it's a breaking change.

WDYT?

elasticmachine · 2022-10-25T14:35:52Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-11-07T07:47:02.081+0000
Duration: 19 min 20 sec

Test stats 🧪

Test	Results
Failed	0
Passed	2
Skipped	0
Total	2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2022-10-25T14:36:03Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚 2.694
Classes	100.0% (`0/0`)	💚 2.694
Methods	25.0% (`1/4`)	👎 -66.012
Lines	100.0% (`0/0`)	💚 8.422
Conditionals	100.0% (`0/0`)	💚

kfirpeled · 2022-10-25T15:25:07Z

packages/cloud_security_posture/data_stream/findings/agent/stream/eks.yml.hbs

+runtimeCfg:
+    activated_rules:
+        cis_eks:
+        - cis_3_1_4


I might be wrong but I think you're missing indentation here

It also works this way, but I'll change the indentation to be aligned with the original format

kfirpeled · 2022-10-25T15:25:42Z

packages/cloud_security_posture/data_stream/findings/agent/stream/eks.yml.hbs

+    activated_rules:
+        cis_eks:
+        - cis_3_1_4
+        - cis_5_4_5


do you mind sorting all the rules? it could be really helpful for scanning the list

kfirpeled · 2022-10-25T15:26:06Z

packages/cloud_security_posture/manifest.yml

  - security
 conditions:
-  kibana.version: "^8.5.0"
+  kibana.version: "^8.6.0"


kfirpeled

We should remove the declaration of runtimeCfg - otherwise it will still be present in the UI

ofiriro3 · 2022-10-26T08:40:15Z

We should remove the declaration of runtimeCfg - otherwise it will still be present in the UI

I am not sure that I understand what you meant. RuntimeCfg only appears in the .hbs files, so the rule configuration will be under runTimeConfig. Can you elaborate ?

kfirpeled · 2022-10-26T11:31:59Z

We should remove the declaration of runtimeCfg - otherwise it will still be present in the UI

I am not sure that I understand what you meant. RuntimeCfg only appears in the .hbs files, so the rule configuration will be under runTimeConfig. Can you elaborate ?

Did you check it doesn't appear in the fleet UI? while editing/adding kspm integration

kfirpeled · 2022-10-26T16:28:09Z

packages/cloud_security_posture/data_stream/findings/agent/stream/eks.yml.hbs

-{{runtimeCfg}}
-{{/if}}
+
+runtimeCfg:


looking at cloudbeat tests I believe the key is runtime_cfg.

Nice catch, I only caught it when I run the E2E test

ofiriro3 · 2022-11-06T11:48:05Z

Finish working on this one - it is blocked until we will deal with the forward-compatible mechanism

olegsu · 2022-11-07T08:09:24Z

Finish working on this one - it is blocked until we will deal with the forward-compatible mechanism
What is the forward compatibility issue here?

It's more a deprecation of a feature, not changes in the structure, right?

kfirpeled · 2022-11-07T19:13:01Z

packages/cloud_security_posture/changelog.yml

 # newer versions go on top
+- version: "1.0.6"
+  changes:
+    - description: Removing the rule data yaml


Suggested change

- description: Removing the rule data yaml

- description: Removed `runtime_cfg` variable

ofiriro3 · 2022-11-09T08:59:20Z

/test

ofiriro3 added 2 commits October 25, 2022 17:17

removing data.yaml

1583ed9

Merge remote-tracking branch 'origin/main'

d994939

# Conflicts: # packages/cloud_security_posture/changelog.yml # packages/cloud_security_posture/manifest.yml

ofiriro3 added 8.6 candidate Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Oct 25, 2022

ofiriro3 added 2 commits October 25, 2022 17:24

updating kibana minimal version to 8.6.0

3a7ef7c

remove redundant space

1447919

ofiriro3 commented Oct 25, 2022

View reviewed changes

ofiriro3 marked this pull request as ready for review October 25, 2022 14:30

ofiriro3 requested a review from a team as a code owner October 25, 2022 14:30

ofiriro3 requested a review from kfirpeled October 25, 2022 14:36

kfirpeled reviewed Oct 25, 2022

View reviewed changes

kfirpeled requested changes Oct 25, 2022

View reviewed changes

ofiriro3 added 3 commits October 26, 2022 10:35

Fixing indentation

a8da4fb

Ordering EKS rules

2fedd1c

Ordering Vanilla rules

611edfd

ofiriro3 requested a review from kfirpeled October 26, 2022 08:40

Remove the cfg config

0e38205

kfirpeled reviewed Oct 26, 2022

View reviewed changes

ofiriro3 added 2 commits November 6, 2022 12:58

Remove the cfg config

570f558

merge main to my branch + updating changelog.yml

a9d4c52

ofiriro3 requested a review from kfirpeled November 6, 2022 11:39

Update pull request in changelog.yml

3124406

kfirpeled changed the title ~~Remove data yaml~~ [Cloud Posture] Remove runtime_cfg var Nov 7, 2022

kfirpeled approved these changes Nov 7, 2022

View reviewed changes

ofiriro3 merged commit 92ceebb into elastic:main Nov 8, 2022

	- description: Removing the rule data yaml
	- description: Removed `runtime_cfg` variable

Conversation

ofiriro3 commented Oct 25, 2022 • edited by kfirpeled Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

elasticmachine commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kfirpeled left a comment

Choose a reason for hiding this comment

Uh oh!

ofiriro3 commented Oct 26, 2022

Uh oh!

kfirpeled commented Oct 26, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ofiriro3 commented Nov 6, 2022

Uh oh!

olegsu commented Nov 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ofiriro3 commented Nov 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ofiriro3 commented Oct 25, 2022 •

edited by kfirpeled

Loading

elasticmachine commented Oct 25, 2022 •

edited

Loading

elasticmachine commented Oct 25, 2022 •

edited

Loading

olegsu commented Nov 7, 2022 •

edited

Loading