[AWS] Remove duplicate fields from agent.yml and use ecs.yml for ECS fields#4657
Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom Nov 17, 2022
Merged
[AWS] Remove duplicate fields from agent.yml and use ecs.yml for ECS fields#4657kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng merged 2 commits intoelastic:mainfrom
Conversation
4 tasks
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
zmoog
approved these changes
Nov 16, 2022
Contributor
zmoog
left a comment
There was a problem hiding this comment.
The .md files in docs mostly have a few description changes, but it's probably due to the switch to the ECS field definitions.
LGTM.
Contributor
Author
|
@zmoog Yep exactly :) Thanks! |
4 tasks
P1llus
approved these changes
Nov 17, 2022
4 tasks
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to #4567, this PR is to remove all duplicate fields from
agent.ymlfiles from all data streams under AWS package and useecs.ymlfile to document all ECS fields to avoid re-defining these fields again.Checklist
changelog.ymlfile.