[gcp] Add logic to handle scalar request.policy values on audit#5231
Merged
marc-gr merged 3 commits intoelastic:mainfrom Feb 23, 2023
Merged
[gcp] Add logic to handle scalar request.policy values on audit#5231marc-gr merged 3 commits intoelastic:mainfrom
marc-gr merged 3 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
taylor-swanson
approved these changes
Feb 13, 2023
Contributor
taylor-swanson
left a comment
There was a problem hiding this comment.
LGTM, my only suggestion would be adding a pipeline test if we had a sample log to exercise this behavior.
Contributor
|
LGTM , Agree to the comment from Taylor to add a pipeline test if possible. |
|
Package gcp - 2.16.2 containing this change is available at https://epr.elastic.co/search?package=gcp |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 20, 2023
…tic#5231) * Add logic to handle scalar request.policy values on audit * Add PR number to changelog * Add test
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 21, 2023
…tic#5231) * Add logic to handle scalar request.policy values on audit * Add PR number to changelog * Add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds logic to move
request.policyintorequest.policy_valuewhen it is not an object and avoid indexing errors.Checklist
changelog.ymlfile.