Skip to content

Add missing rule templates#6067

Merged
orestisfl merged 1 commit intoelastic:mainfrom
orestisfl:missing-rules
May 9, 2023
Merged

Add missing rule templates#6067
orestisfl merged 1 commit intoelastic:mainfrom
orestisfl:missing-rules

Conversation

@orestisfl
Copy link
Contributor

@orestisfl orestisfl commented May 3, 2023 •
edited
Loading

What does this PR do?

Generate missing rule templates for new rules.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

screenshot-2023-05-04T16:48:05 IDT

@orestisfl orestisfl requested a review from a team as a code owner May 3, 2023 08:23
This was referenced May 3, 2023
Closed
Closed
@elasticmachine
Copy link

elasticmachine commented May 3, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-08T06:46:39.855+0000

  • Duration: 14 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 3, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -73.649
Lines 100.0% (0/0) 💚 3.719
Conditionals 100.0% (0/0) 💚

oren-zohar
oren-zohar requested changes May 3, 2023
View reviewed changes
Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping me when the manifest and change-log are updated, I'm supprised it didn't fail the CI here

@orestisfl
Copy link
Contributor Author

orestisfl commented May 3, 2023

Hey @kfirpeled, a bit confused about how the backporting is going to work since we have two preview versions right now. Do we have to follow the instructions in https://github.com/elastic/integrations/blob/main/docs/developer_workflow_bug_fix_older_package_version.md?

@kfirpeled
Copy link
Contributor

kfirpeled commented May 3, 2023 •
edited
Loading

@orestisfl great question, we have a guideline (based on what you shared) - I'll send it to you

Also, you didn't mention elastic/csp-security-policies#192 which is also missing from the benchmark

@orestisfl orestisfl mentioned this pull request May 4, 2023
Merged
4 tasks
@kfirpeled
Copy link
Contributor

kfirpeled commented May 4, 2023

ping me when the manifest and change-log are updated, I'm supprised it didn't fail the CI here

There's no check for adding anything to the manifest or the changelog

@orestisfl orestisfl requested a review from oren-zohar May 8, 2023 06:46
@orestisfl
Copy link
Contributor Author

orestisfl commented May 8, 2023

Updated, cherry-picked the commit from the backport branch

@orestisfl orestisfl requested a review from kfirpeled May 8, 2023 06:47
@orestisfl orestisfl merged commit 585feed into elastic:main May 9, 2023
@orestisfl orestisfl deleted the missing-rules branch May 9, 2023 07:50
@elasticmachine
Copy link

elasticmachine commented May 10, 2023

Package cloud_security_posture - 1.3.0-preview10 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

elasticmachine commented May 10, 2023

Package cloud_security_posture - 1.3.0-preview91 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

elasticmachine commented May 25, 2023

Package cloud_security_posture - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 9, 2023

Package cloud_security_posture - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@orestisfl orestisfl self-assigned this Jul 10, 2023
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment