Memcached Integration - Updated documentation to fix punctuations#6303
Merged
muthu-mps merged 3 commits intoelastic:mainfrom May 25, 2023
Merged
Memcached Integration - Updated documentation to fix punctuations#6303muthu-mps merged 3 commits intoelastic:mainfrom
muthu-mps merged 3 commits intoelastic:mainfrom
Conversation
🌐 Coverage report
|
devamanv
approved these changes
May 24, 2023
shmsr
requested changes
May 25, 2023
Member
shmsr
left a comment
There was a problem hiding this comment.
Also, can we rename the PR title to:
[Memcached] Update documentation to fix punctuation
| # newer versions go on top | ||
| - version: "0.4.1" | ||
| changes: | ||
| - description: Updated documentation |
Member
There was a problem hiding this comment.
Suggested change
| - description: Updated documentation | |
| - description: Update documentation |
https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?h=v2.36.1#n181
Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior.
Commit messages, changelog, PR titles, etc. ideally should follow this.
|
Package memcached - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=memcached |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #5997
How to test this PR locally
Install the Memcached integration and verify metrics collection.
Verify the documentation change is getting reflected.
Related issues