Skip to content

[AWS] Support Cloudtrail tlsDetails field#6352

Merged
kaiyan-sheng merged 9 commits intoelastic:mainfrom
legoguy1000:6300-tlsdetails
Sep 28, 2023
Merged

[AWS] Support Cloudtrail tlsDetails field#6352
kaiyan-sheng merged 9 commits intoelastic:mainfrom
legoguy1000:6300-tlsdetails

Conversation

@legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented May 28, 2023

What does this PR do?

Parses tlsDetails field

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner May 28, 2023 18:52
@elasticmachine
Copy link

elasticmachine commented May 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-27T21:11:14.085+0000

  • Duration: 55 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@botelastic
Copy link

botelastic bot commented Jun 27, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 27, 2023
@legoguy1000
Copy link
Contributor Author

legoguy1000 commented Jun 28, 2023

bump

@botelastic botelastic bot removed the Stalled label Jun 28, 2023
@botelastic
Copy link

botelastic bot commented Jul 28, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 28, 2023
@botelastic botelastic bot removed the Stalled label Jul 28, 2023
@botelastic
Copy link

botelastic bot commented Aug 27, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 27, 2023
@botelastic
Copy link

botelastic bot commented Sep 26, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Sep 26, 2023
@kaiyan-sheng kaiyan-sheng reopened this Sep 26, 2023
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner September 26, 2023 21:34
@botelastic botelastic bot removed the Stalled label Sep 26, 2023
@legoguy1000
Copy link
Contributor Author

legoguy1000 commented Sep 26, 2023 via email

@efd6
Copy link
Contributor

efd6 commented Sep 27, 2023

/test

efd6
efd6 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the builder can be made to run and pass.

kaiyan-sheng
kaiyan-sheng approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the change!

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍
Classes 94.444% (17/18) 👍
Methods 86.047% (259/301) 👍 0.093
Lines 86.062% (7558/8782) 👍 0.024
Conditionals 100.0% (0/0) 💚

efd6
efd6 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@kaiyan-sheng kaiyan-sheng merged commit fc1bfbe into elastic:main Sep 28, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 28, 2023

Package aws - 2.5.0 containing this change is available at https://epr.elastic.co/search?package=aws

@legoguy1000 legoguy1000 deleted the 6300-tlsdetails branch September 28, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cloudtrail Ingest Pipeline: Does not parse tlsDetails structure

5 participants

@legoguy1000 @elasticmachine @efd6 @kaiyan-sheng @andrewkroh