Skip to content

[ti_misp] Ensure event.kind is correctly set for pipeline errors#6633

Merged
efd6 merged 4 commits intoelastic:mainfrom
MakoWish:6582-ti_misp
Jun 21, 2023
Merged

[ti_misp] Ensure event.kind is correctly set for pipeline errors#6633
efd6 merged 4 commits intoelastic:mainfrom
MakoWish:6582-ti_misp

Conversation

@MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jun 20, 2023

What does this PR do?

Modify ti_misp integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 20, 2023 20:15
@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T21:50:05.000+0000

  • Duration: 15 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 20, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 5.172
Classes 100.0% (2/2) 💚 5.172
Methods 100.0% (30/30) 💚 4.332
Lines 86.536% (617/713) 👎 -4.426
Conditionals 100.0% (0/0) 💚

@efd6 efd6 mentioned this pull request Jun 21, 2023
Closed
@efd6 efd6 merged commit 2e9a0fc into elastic:main Jun 21, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 21, 2023

Package ti_misp - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=ti_misp

@MakoWish MakoWish deleted the 6582-ti_misp branch June 21, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

Integration:ti_misp MISP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MakoWish @elasticmachine @efd6 @andrewkroh