Skip to content

[GCP] Convert some dashboards to lens#7014

Merged
P1llus merged 5 commits intoelastic:mainfrom
P1llus:package_gcp_lens
Jul 19, 2023
Merged

[GCP] Convert some dashboards to lens#7014
P1llus merged 5 commits intoelastic:mainfrom
P1llus:package_gcp_lens

Conversation

@P1llus
Copy link
Member

@P1llus P1llus commented Jul 19, 2023 •
edited
Loading

What does this PR do?

Converts the Audit, VPCFlow and Firewall related dashboards to lens, format or layout did not change. The audit dashboard had a duplicate dashboard, removed one of them.
Also removed the tags that should not be exported, must have been from an earlier mistake.

Most visualizations was already lens, removed some markdown using TVSB, and changing up the filters on the rest.

Bumped format_version to 2.7.0 and fixes event.type/category for firewall/audit/vpcflow.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus added enhancement New feature or request Team:Security-External Integrations Integration:gcp Google Cloud Platform labels Jul 19, 2023
@P1llus P1llus requested review from a team as code owners July 19, 2023 15:48
@elasticmachine
Copy link

elasticmachine commented Jul 19, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 19, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-19T18:59:04.578+0000

  • Duration: 19 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 58
Skipped 0
Total 58

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

kcreddy
kcreddy approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

CI looks to be complaining about array type on following fields. Probably need to change to flattened
https://github.com/P1llus/integrations/blob/package_gcp_lens/packages/gcp/data_stream/audit/fields/fields.yml#L21
https://github.com/P1llus/integrations/blob/package_gcp_lens/packages/gcp/data_stream/audit/fields/fields.yml#L100
https://github.com/P1llus/integrations/blob/package_gcp_lens/packages/gcp/data_stream/firewall/fields/fields.yml#L34

@P1llus
Copy link
Member Author

P1llus commented Jul 19, 2023

LGTM 👍🏼

CI looks to be complaining about array type on following fields. Probably need to change to flattened https://github.com/P1llus/integrations/blob/package_gcp_lens/packages/gcp/data_stream/audit/fields/fields.yml#L21 https://github.com/P1llus/integrations/blob/package_gcp_lens/packages/gcp/data_stream/audit/fields/fields.yml#L100 https://github.com/P1llus/integrations/blob/package_gcp_lens/packages/gcp/data_stream/firewall/fields/fields.yml#L34

Thanks!
Yeah almost, the sub-fields are defined, so nested is better than flattened in this case, the type "array" does not exist, even though I have seen it been defined that way in multiple places.

@elasticmachine
Copy link

elasticmachine commented Jul 19, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 10.526
Classes 100.0% (6/6) 💚 10.526
Methods 89.623% (95/106) 👍 4.859
Lines 96.0% (1464/1525) 👍 10.331
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit d6b0497 into elastic:main Jul 19, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 19, 2023

Package gcp - 2.23.0 containing this change is available at https://epr.elastic.co/search?package=gcp

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Aug 4, 2023
Closed
10 tasks
@efd6 efd6 mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Integration:gcp Google Cloud Platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@P1llus @elasticmachine @kcreddy