[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream by tetianakravchenko · Pull Request #7155 · elastic/integrations

tetianakravchenko · 2023-07-26T15:50:24Z

What does this PR do?

remove duplicated fields
instead of using wildcard in the field name - use predefined field names
- for azure.dimensions - there are no dimensions
Note: only 1 metric - StorageUsed has a dimension, but we do not use it https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerregistry-registries-metrics
- list of metrics - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerregistry-registries-metrics
used fields for dimensions:
- cloud.region
- azure.resource.id - this field includes azure.subscription_id, azure.resource.group, azure.resource.name, format:
```
 /subscriptions/{azure.subscription_id}/resourceGroups/{azure.resource.group}providers/Microsoft.ContainerRegistry/registries/{azure.resource.name}
```
- azure.timegrain
  
  NOTE: there is an issue with timegrain as it does not work as expected, I will create an issue and link it here.
metrics - use predefined metrics - since in the configuration is defined list of metrics

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

elasticmachine · 2023-07-26T16:05:51Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-08-16T15:55:32.112+0000
Duration: 14 min 6 sec

Test stats 🧪

Test	Results
Failed	0
Passed	33
Skipped	0
Total	33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2023-07-26T16:06:03Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`3/3`)	💚
Files	100.0% (`3/3`)	💚
Classes	100.0% (`3/3`)	💚
Methods	73.333% (`22/30`)	👍
Lines	100.0% (`21/21`)	💚
Conditionals	100.0% (`0/0`)	💚

zmoog · 2023-07-28T18:45:50Z

@tetianakravchenko I see #7162 it is the tracking issue for the timegrain problem.

Do you see this problem as a blocker for this PR?

agithomas · 2023-07-31T09:55:58Z

Which field will hold the names of the images, tags, other meta data information ? Shouldn't they be dimensions?

tetianakravchenko · 2023-08-02T10:52:59Z

@agithomas

Which field will hold the names of the images, tags, other meta data information ? Shouldn't they be dimensions?

There is no such information available in this datastream, here is the list of metrics - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerregistry-registries-metrics

as you see those metrics are on the registry level, not for each specific image

all available fields:

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

tetianakravchenko · 2023-08-03T08:02:53Z

/test

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

agithomas

LGTM!

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

elasticmachine · 2023-08-16T16:35:39Z

Package azure_metrics - 1.0.22 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

ritalwar · 2023-08-25T09:58:34Z

packages/azure_metrics/data_stream/container_registry/fields/fields.yml

+    - name: agent_pool_cpu_time.total
+      type: float
+      metric_type: gauge
+      unis: s


Typo: "unis" should be "unit".

tetianakravchenko added 2 commits July 25, 2023 15:52

registry: add dimensions

c19a88f

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

remove metrics.* field; add agent.id field; add full list of metrics

fa9b5cf

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

tetianakravchenko requested a review from a team as a code owner July 26, 2023 15:50

tetianakravchenko requested review from agithomas and zmoog July 26, 2023 15:51

tetianakravchenko mentioned this pull request Jul 26, 2023

[Azure] TSDB enablement - track all metrics data streams #7140

Closed

31 tasks

zmoog approved these changes Jul 28, 2023

View reviewed changes

andrewkroh added the Integration:azure Azure Logs label Aug 1, 2023

fix changelog merge conflict

d8a9ee3

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

add azure geolocation dimension field; fix merge conflicts

72fd39c

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

agithomas approved these changes Aug 14, 2023

View reviewed changes

fix merge conflicts

57703bb

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

tetianakravchenko merged commit 0cd1a8e into elastic:main Aug 16, 2023

tetianakravchenko deleted the azure-container-registry-tsdb branch August 16, 2023 16:14

ritalwar reviewed Aug 25, 2023

View reviewed changes

andrewkroh added Integration:azure_metrics Azure Resource Metrics and removed Integration:azure Azure Logs labels Jul 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream#7155

[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream#7155
tetianakravchenko merged 5 commits intoelastic:mainfrom
tetianakravchenko:azure-container-registry-tsdb

tetianakravchenko commented Jul 26, 2023 •

edited

Loading

Uh oh!

elasticmachine commented Jul 26, 2023 •

edited

Loading

Build stats

Test stats 🧪

Uh oh!

elasticmachine commented Jul 26, 2023 •

edited

Loading

Uh oh!

zmoog commented Jul 28, 2023

Uh oh!

agithomas commented Jul 31, 2023

Uh oh!

tetianakravchenko commented Aug 2, 2023

Uh oh!

tetianakravchenko commented Aug 3, 2023

Uh oh!

agithomas left a comment

Uh oh!

elasticmachine commented Aug 16, 2023

Uh oh!

ritalwar Aug 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

tetianakravchenko commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Screenshots

Uh oh!

elasticmachine commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

elasticmachine commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

zmoog commented Jul 28, 2023

Uh oh!

agithomas commented Jul 31, 2023

Uh oh!

tetianakravchenko commented Aug 2, 2023

Uh oh!

tetianakravchenko commented Aug 3, 2023

Uh oh!

agithomas left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 16, 2023

Uh oh!

ritalwar Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tetianakravchenko commented Jul 26, 2023 •

edited

Loading

elasticmachine commented Jul 26, 2023 •

edited

Loading

elasticmachine commented Jul 26, 2023 •

edited

Loading