Skip to content

Migrate GCP Billing input control to new control panel#7249

Merged
kush-elastic merged 2 commits intoelastic:mainfrom
kush-elastic:lens_migration-gcp-billing
Aug 8, 2023
Merged

Migrate GCP Billing input control to new control panel#7249
kush-elastic merged 2 commits intoelastic:mainfrom
kush-elastic:lens_migration-gcp-billing

Conversation

@kush-elastic
Copy link
Contributor

@kush-elastic kush-elastic commented Aug 4, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate GCP Billing visualizations to the lens in the current Kibana version 8.3.0 itself.

  • Statistics for GCP Billing Lens migration:

Migration stats

  Before Migration After Migration
Dashboad Name Lens Visualization Old control panel Lens Visualization New input controls
Billing overview 4 0 1 4 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.7.1 itself.

Related issues

Notes

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Aug 4, 2023
Closed
5 tasks
@kush-elastic kush-elastic marked this pull request as ready for review August 4, 2023 06:58
@kush-elastic kush-elastic requested review from a team as code owners August 4, 2023 06:58
@kush-elastic kush-elastic self-assigned this Aug 4, 2023
@kush-elastic kush-elastic added enhancement New feature or request dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Aug 4, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-04T06:51:02.946+0000

  • Duration: 19 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 64
Skipped 0
Total 64

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 2.813
Classes 100.0% (6/6) 💚 2.813
Methods 87.826% (101/115) 👎 -4.378
Lines 96.0% (1464/1525) 👍 5.228
Conditionals 100.0% (0/0) 💚

kcreddy
kcreddy approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy added the Integration:gcp Google Cloud Platform label Aug 7, 2023
@rajvi-patel-22 rajvi-patel-22 self-requested a review August 8, 2023 12:47
rajvi-patel-22
rajvi-patel-22 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit a2a2841 into elastic:main Aug 8, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 8, 2023

Package gcp - 2.25.0 containing this change is available at https://epr.elastic.co/search?package=gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@endorama endorama endorama approved these changes

@kcreddy kcreddy kcreddy approved these changes

+1 more reviewer

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kush-elastic kush-elastic

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:gcp Google Cloud Platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[O11y][GCP Billing] Lens Migration

6 participants

@kush-elastic @elasticmachine @endorama @kcreddy @rajvi-patel-22 @kush-crest