Skip to content

[AWS][cloudwatch_metrics] Enable TSDB by default for cloudwatch metrics data stream#7262

Merged
tetianakravchenko merged 3 commits intoelastic:mainfrom
tetianakravchenko:aws-cloudwatch-enable-tsdb
Aug 10, 2023
Merged

[AWS][cloudwatch_metrics] Enable TSDB by default for cloudwatch metrics data stream#7262
tetianakravchenko merged 3 commits intoelastic:mainfrom
tetianakravchenko:aws-cloudwatch-enable-tsdb

Conversation

@tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Aug 4, 2023

What does this PR do?

Enable TSDB by default for cloudwatch metrics data stream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

tested with TSDB-migration-test-kit:

Details 
Testing data stream metrics-aws.cloudwatch_metrics-default.
Index being used for the documents is .ds-metrics-aws.cloudwatch_metrics-default-2023.08.04-000001.
Index being used for the settings and mappings is .ds-metrics-aws.cloudwatch_metrics-default-2023.08.04-000001.

The time series fields for the TSDB index are: 
        - dimension (4 fields):
                - agent.id
                - aws.dimensions.fingerprint
                - cloud.account.id
                - cloud.region
        - gauge (2 fields):
                - aws.ec2.metrics.CPUUtilization.avg
                - aws.ec2.metrics.CPUUtilization.max
        - routing_path (4 fields):
                - agent.id
                - aws.dimensions.fingerprint
                - cloud.account.id
                - cloud.region

Index tsdb-index-enabled successfully created.

Copying documents from .ds-metrics-aws.cloudwatch_metrics-default-2023.08.04-000001 to tsdb-index-enabled...
All 474 documents taken from index .ds-metrics-aws.cloudwatch_metrics-default-2023.08.04-000001 were successfully placed to index tsdb-index-enabled.

Related issues

Screenshots

@tetianakravchenko
Enable TSDB by default for cloudwatch metrics data stream; set stack …
069eda6 
…restriction to 8.9.0

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner August 4, 2023 14:45
@elasticmachine
Copy link

elasticmachine commented Aug 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-10T07:46:44.156+0000

  • Duration: 53 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -1.01
Classes 94.444% (17/18) 👎 -1.01
Methods 85.953% (257/299) 👎 -2.115
Lines 86.011% (7501/8721) 👎 -2.064
Conditionals 100.0% (0/0) 💚

@tetianakravchenko
fix merge conflicts
b455db4 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko merged commit d8f5b94 into elastic:main Aug 10, 2023
@tetianakravchenko tetianakravchenko deleted the aws-cloudwatch-enable-tsdb branch August 10, 2023 09:05
@elasticmachine
Copy link

elasticmachine commented Aug 10, 2023

Package aws - 1.52.0 containing this change is available at https://epr.elastic.co/search?package=aws

@constanca-m constanca-m mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

No one assigned

Labels

Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tetianakravchenko @elasticmachine @kaiyan-sheng @andrewkroh