[Azure][compute_vm] Add dimensions, metric_type to the compute_vm datastream; remove dupl…#7293
Merged
tetianakravchenko merged 9 commits intoelastic:mainfrom Aug 28, 2023
Merged
Conversation
…icated fields; extend azure.dimensions.* field with exact fields Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
| @@ -1,6 +1,7 @@ | |||
| - name: azure.compute_vm.*.* | |||
| type: object | |||
| metric_type: gauge | |||
Contributor
Author
There was a problem hiding this comment.
Note: for float it is not possible to use format:
- name: azure.compute_vm.*.*
type: float
metric_type: gauge
it causes this error:
Failed to parse mapping: No field type matched on [duck], possible values are [object, string, long, double, boolean, date, binary]
31 tasks
🌐 Coverage report
|
Contributor
Author
|
/test |
…tion] Reason: Mapping definition for [*] has unsupported parameters: [meta : {metric_type=gauge}]
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
| - azure | ||
| conditions: | ||
| kibana.version: "^8.3.0" | ||
| kibana.version: "^8.9.0" |
Contributor
Author
There was a problem hiding this comment.
FYI: It was intriduced due to this error:
[2023-08-17T08:30:18.282Z] Error: error running package asset tests: could not complete test run: can't install the package: can't install the package: could not install package; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"mapper_parsing_exception: [mapper_parsing_exception] Reason: Mapping definition for [*] has unsupported parameters: [meta : {metric_type=gauge}]"}
in CI was used stack version defined as a restriction: ../../build/elastic-package stack up -d -v --version 8.3.0
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
zmoog
approved these changes
Aug 23, 2023
gpop63
approved these changes
Aug 25, 2023
|
Package azure_metrics - 1.0.28 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…icated fields; extend azure.dimensions.* field with exact fields
What does this PR do?
agent.idazure.dimensions.*azure.namespace- there might be multiple sources of metrics - for example for the same windows instance there can be availableMicrosoft.Compute/virtualMachinesandAzure.VM.Windows.GuestMetricsmetrics, both does not havedimensionscloud.regioncloud.instance.id- this is mainly added to follow the same rules as for aws/gcp,azure.resource.idshould be unique enoughazure.resource.idazure.timegrainagent.idfieldmetric_typeto theazure.compute_vm.*.*metricthere is planned a release with changes in spec, that fix the
elastic-package builderrorChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots