Add check for empty fields in azure integration#741
Merged
narph merged 5 commits intoelastic:masterfrom Mar 2, 2021
narph:no-value
Merged
Add check for empty fields in azure integration#741narph merged 5 commits intoelastic:masterfrom narph:no-value
narph merged 5 commits intoelastic:masterfrom
narph:no-value
Conversation
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mtojek
reviewed
Feb 24, 2021
Contributor
mtojek
left a comment
There was a problem hiding this comment.
The build is failing due to this: elastic/beats#24198 . If it's not an urgent issue I would wait for the correct Docker images.
Apart from this, LGTM
BTW we have introduced a Terraform service deployer that should also support Azure (if only our CI does/has secrets). You can schedule some time in the future to research this area and create a couple of tests.
Contributor
|
I think you can rebase it against master now. |
mtojek
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds check for empty fields in azure integration
Checklist
changelog.ymlfile.