Skip to content

[O11y][Azure Metrics] Migrate Compute VMs Overview dashboard to lens#7508

Merged
rajvi-patel-22 merged 6 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration_azure_metrics_compute_vm_overview
Sep 8, 2023
Merged

[O11y][Azure Metrics] Migrate Compute VMs Overview dashboard to lens#7508
rajvi-patel-22 merged 6 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration_azure_metrics_compute_vm_overview

Conversation

@rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Aug 23, 2023

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Compute VMs Overview visualizations to the lens in the current Kibana version 8.4.0 itself.

  • Statistics for Compute VMs Overview Lens migration:

Migration stats

  Before Migration     After Migration    
  Lens Visualization Old Input Controls Lens Visualization New control panels
[Azure Metrics] Compute VMs Overview 0 8 1 8 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team August 23, 2023 13:37
@rajvi-patel-22 rajvi-patel-22 self-assigned this Aug 23, 2023
@rajvi-patel-22 rajvi-patel-22 added enhancement New feature or request dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:azure_metrics Azure Resource Metrics labels Aug 23, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-08T11:09:47.188+0000

  • Duration: 15 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 75.758% (25/33) 👎 -11.742
Lines 100.0% (32/32) 💚 8.02
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review August 24, 2023 09:32
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner August 24, 2023 09:32
zmoog
zmoog approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is there a reason why the "VM Disk Reads [Azure Metrics]" is the only panel having the "[Azure Metrics]" suffix?

CleanShot 2023-08-25 at 06 07 04@2x

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Aug 28, 2023 •
edited
Loading

nit: Is there a reason why the "VM Disk Reads [Azure Metrics]" is the only panel having the "[Azure Metrics]" suffix?

@zmoog I'm not sure why only one panel have the "[Azure Metrics]" suffix. We have just migrated the visualizations to the lens keeping titles as it is. But according to the best practices "[Azure Metrics]" suffix should be added to the all panel titles. I have created an issue.

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Aug 28, 2023
Closed
8 tasks
@rajvi-patel-22
Merge branch 'main' of github.com:rajvi-elastic/integrations into len…
08de02d 
…s_migration_azure_metrics_compute_vm_overview
@agithomas
Copy link
Contributor

agithomas commented Aug 30, 2023 •
edited
Loading

But according to the best practices "[Azure Metrics]" suffix should be added to the all panel titles.

Can you please help with the link to the guidelines that highlight this as a best practice? I think, such a guideline must be revisited.

I agree with @zmoog on removing the title.

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Aug 31, 2023

Can you please help with the link to the guidelines that highlight this as a best practice? I think, such a guideline must be revisited.

Yes @agithomas. Here is the official elastic doc for integration dashboard guidelines.

@zmoog
Copy link
Contributor

zmoog commented Sep 8, 2023

Since this PR is ready, I would not hold it back more.

I suggest merging this and opening a dedicated PR to track the need to align the integrations to the guidelines.

@rajvi-patel-22 rajvi-patel-22 merged commit c642443 into elastic:main Sep 8, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 8, 2023

Package azure_metrics - 1.0.38 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:azure_metrics Azure Resource Metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajvi-patel-22 @elasticmachine @agithomas @zmoog