Refactoring GCP credentials -Fix continuation#7546
Merged
animehart merged 2 commits intoelastic:mainfrom Aug 25, 2023
animehart:ricky-refactor-fix-gcp
Merged
Refactoring GCP credentials -Fix continuation#7546animehart merged 2 commits intoelastic:mainfrom animehart:ricky-refactor-fix-gcp
animehart merged 2 commits intoelastic:mainfrom
animehart:ricky-refactor-fix-gcp
Conversation
mitodrummer
reviewed
Aug 25, 2023
opauloh
reviewed
Aug 25, 2023
opauloh
approved these changes
Aug 25, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Package cloud_security_posture - 1.5.2-preview2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Contributor
|
@animehart was it tested with |
|
Package cloud_security_posture - 1.5.2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my previous PR (#7537) I forgot to include the changelog and manifest yml change
as such It didnt trigger the build to see my changes