Skip to content

[cisco_secure_email_gateway] Remove unused field mappings#7875

Merged
andrewkroh merged 1 commit intoelastic:mainfrom
andrewkroh:cisco_secure_email_gateway/bugfix/remove-filepath-type
Sep 20, 2023
Merged

[cisco_secure_email_gateway] Remove unused field mappings#7875
andrewkroh merged 1 commit intoelastic:mainfrom
andrewkroh:cisco_secure_email_gateway/bugfix/remove-filepath-type

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 19, 2023

What does this PR do?

The type and filepath fields were unused so this removes them.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_secure_email_gateway Cisco Secure Email Gateway labels Sep 19, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner September 19, 2023 15:49
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 19, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-19T20:11:20.233+0000

  • Duration: 16 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh
[cisco_secure_email_gateway] Remove unused field mappings
fe6a899 
The `type` and `filepath` fields were unused so this removes them.
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 83.333% (10/12) 👎 -10.895
Classes 83.333% (10/12) 👎 -10.895
Methods 89.286% (50/56) 👎 -2.124
Lines 86.819% (606/698) 👎 -0.23
Conditionals 100.0% (0/0) 💚

bhapas
bhapas approved these changes Sep 20, 2023
View reviewed changes
@andrewkroh andrewkroh merged commit 33448f9 into elastic:main Sep 20, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 20, 2023

Package cisco_secure_email_gateway - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=cisco_secure_email_gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

@bhapas bhapas bhapas approved these changes

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues Integration:cisco_secure_email_gateway Cisco Secure Email Gateway

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewkroh @elasticmachine @efd6 @bhapas