Skip to content

[GCP] Update null checks and if checks in the rename#7934

Merged
ishleenk17 merged 2 commits intoelastic:mainfrom
ishleenk17:main
Sep 25, 2023
Merged

[GCP] Update null checks and if checks in the rename#7934
ishleenk17 merged 2 commits intoelastic:mainfrom
ishleenk17:main

Conversation

@ishleenk17
Copy link
Member

@ishleenk17 ishleenk17 commented Sep 22, 2023

  • Bug

What does this PR do?

This PR adds the if check for event.original and the ignore_missing check for the renaming of message to event.original
The packages where the changes are made are as below:

  • loadbalancing_logs
  • vpcflow
  • firewall
  • audit
  • dns

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ishleenk17 ishleenk17 requested a review from a team September 22, 2023 06:34
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T06:36:04.635+0000

  • Duration: 19 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 1.471
Classes 100.0% (6/6) 💚 1.471
Methods 87.826% (101/115) 👎 -9.858
Lines 96.013% (1469/1530) 👍 2.384
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 marked this pull request as ready for review September 22, 2023 08:21
@ishleenk17 ishleenk17 requested review from a team as code owners September 22, 2023 08:21
zmoog
zmoog approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kcreddy
kcreddy approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@ishleenk17 ishleenk17 merged commit bc498fa into elastic:main Sep 25, 2023
@ishleenk17 ishleenk17 mentioned this pull request Sep 25, 2023
Closed
35 tasks
@ishleenk17 ishleenk17 changed the title [GCP] Update null checks anf if checks in the rename [GCP] Update null checks and if checks in the rename Sep 25, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023

Package gcp - 2.29.1 containing this change is available at https://epr.elastic.co/search?package=gcp

@ishleenk17 ishleenk17 self-assigned this Sep 25, 2023
@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@kcreddy kcreddy kcreddy approved these changes

Assignees

@ishleenk17 ishleenk17

Labels

Integration:gcp Google Cloud Platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ishleenk17 @elasticmachine @zmoog @kcreddy @andrewkroh