Skip to content

azure: fix mappings for azure.activitylogs.claims.*#7979

Merged
andrewkroh merged 1 commit intoelastic:mainfrom
efd6:7974-azure
Sep 26, 2023
Merged

azure: fix mappings for azure.activitylogs.claims.*#7979
andrewkroh merged 1 commit intoelastic:mainfrom
efd6:7974-azure

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Sep 26, 2023 •
edited
Loading

What does this PR do?

See title.

After the change the index template shows this (cf.):

      "dynamic_templates": [
        {
          "azure.activitylogs.identity.claims.*": {
            "path_match": "azure.activitylogs.identity.claims.*",
            "mapping": {
              "type": "keyword"
            }
          }
        },
        {
          "strings_as_keyword": {
            "match_mapping_type": "string",
            "mapping": {
              "ignore_above": 1024,
              "type": "keyword"
            }
          }
        }
      ],

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:azure Azure Logs labels Sep 26, 2023
@efd6 efd6 self-assigned this Sep 26, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T04:41:46.130+0000

  • Duration: 13 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -9.438
Lines 85.003% (2817/3314) 👎 -6.638
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 26, 2023 06:48
@efd6 efd6 requested a review from a team as a code owner September 26, 2023 06:48
@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Contextual comment on this PR -- This field is defined to satisfy elastic-package's validation that all fields are documented. Otherwise, we would not add this at all and defer to the existing strings_as_keyword dynamic mapping.

zmoog
zmoog approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit 551097d into elastic:main Sep 26, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023

Package azure - 1.5.32 containing this change is available at https://epr.elastic.co/search?package=azure

@efd6 efd6 deleted the 7974-azure branch February 5, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:azure Azure Logs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[azure.activity_logs] Missing object_type on 'azure.activitylogs.identity.claims.*'

4 participants

@efd6 @elasticmachine @zmoog @andrewkroh