Skip to content

[ECS][trend_micro_vision_one] Correcting invalid ECS field usages at root-level#7986

Merged
kgeller merged 2 commits intoelastic:mainfrom
kgeller:7808-trend-micro-vision-one
Sep 26, 2023
Merged

[ECS][trend_micro_vision_one] Correcting invalid ECS field usages at root-level#7986
kgeller merged 2 commits intoelastic:mainfrom
kgeller:7808-trend-micro-vision-one

Conversation

@kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 26, 2023

What does this PR do?

Correcting invalid ECS os.* field usages at the root-level

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kgeller kgeller added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:trendmicro Trend Micro Deep Security labels Sep 26, 2023
@kgeller kgeller self-assigned this Sep 26, 2023
@kgeller kgeller mentioned this pull request Sep 26, 2023
Closed
@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T17:45:16.752+0000

  • Duration: 16 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 95.652% (44/46) 👍 7.773
Lines 95.184% (1502/1578) 👎 -0.108
Conditionals 100.0% (0/0) 💚

@kgeller kgeller marked this pull request as ready for review September 26, 2023 18:33
@kgeller kgeller requested a review from a team as a code owner September 26, 2023 18:33
@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

taylor-swanson
taylor-swanson approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller merged commit 6ee2c2c into elastic:main Sep 26, 2023
@kgeller kgeller deleted the 7808-trend-micro-vision-one branch September 26, 2023 18:51
@elasticmachine
Copy link

elasticmachine commented Sep 26, 2023

Package trend_micro_vision_one - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=trend_micro_vision_one

@andrewkroh andrewkroh added Integration:trend_micro_vision_one Trend Micro Vision One and removed Integration:trendmicro Trend Micro Deep Security labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@kgeller kgeller

Labels

bug Something isn't working, use only for issues Integration:trend_micro_vision_one Trend Micro Vision One

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kgeller @elasticmachine @taylor-swanson @andrewkroh