Skip to content

[vectra_detect] Clean up null handling#9151

Merged
chrisberkhout merged 6 commits intoelastic:mainfrom
chrisberkhout:vectra_detect-null-handling
Feb 19, 2024
Merged

[vectra_detect] Clean up null handling#9151
chrisberkhout merged 6 commits intoelastic:mainfrom
chrisberkhout:vectra_detect-null-handling

Conversation

@chrisberkhout
Copy link
Contributor

Proposed commit message

[vectra_detect] Clean up null handling (#)

- Combine alternate value checks into single contains check.
- Combine 'not null and is/not value' checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout added Team:Service-Integrations Label for the Observability Service Integrations team Integration:vectra_detect Vectra Detect bugfix Pull request that fixes a bug issue labels Feb 14, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 14, 2024 15:57
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

chrisberkhout and others added 2 commits February 15, 2024 07:38
…peline/pipeline-audit.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions

12.7% 12.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@chrisberkhout chrisberkhout merged commit d650bc6 into elastic:main Feb 19, 2024
@chrisberkhout chrisberkhout deleted the vectra_detect-null-handling branch February 19, 2024 11:08
@elasticmachine
Copy link

Package vectra_detect - 1.7.2 containing this change is available at https://epr.elastic.co/search?package=vectra_detect

gizas pushed a commit that referenced this pull request Mar 13, 2024
- Combine alternate value checks into single contains check.
- Combine 'not null and is/not value' checks.

---------

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
- Combine alternate value checks into single contains check.
- Combine 'not null and is/not value' checks.

---------

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
- Combine alternate value checks into single contains check.
- Combine 'not null and is/not value' checks.

---------

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:vectra_detect Vectra Detect Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants