Skip to content

Add secrets support to the Azure Metrics integration#9621

Merged
zmoog merged 7 commits intoelastic:mainfrom
zmoog:zmoog/azure-metrics-secrets
Apr 16, 2024
Merged

Add secrets support to the Azure Metrics integration#9621
zmoog merged 7 commits intoelastic:mainfrom
zmoog:zmoog/azure-metrics-secrets

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Apr 16, 2024 •
edited
Loading

Proposed commit message

  • Define the client_secret variable as secret.
  • Bump the package-spec version to 3.1.2 (secrets require at least 3.0.2)
  • Bump Kibana version constraints to ^8.12.0 (^8.10.0 to get secrets support, ^8.12.0 to avoid known bugs)

This ensures their values are encrypted and hidden from the settings UI in Kibana, significantly enhancing security.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Related issues

Screenshots

CleanShot 2024-04-16 at 22 15 47

@zmoog zmoog changed the title Add secrets support to the Azure Logs integration Add secrets support to the Azure Metrics integration Apr 16, 2024
@zmoog zmoog self-assigned this Apr 16, 2024
@zmoog zmoog added the enhancement New feature or request label Apr 16, 2024
@elasticmachine
Copy link

elasticmachine commented Apr 16, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@zmoog
Bump stack version to 8.12.0
37638df 
This version offers a stable implementation of secrets.
@zmoog zmoog marked this pull request as ready for review April 16, 2024 20:32
@zmoog zmoog requested a review from a team as a code owner April 16, 2024 20:32
vigneshshanmugam
vigneshshanmugam approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Apr 16, 2024

💚 Build Succeeded

History

cc @zmoog

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Apr 16, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@zmoog zmoog merged commit 8d670cf into elastic:main Apr 16, 2024
@zmoog zmoog deleted the zmoog/azure-metrics-secrets branch April 16, 2024 20:59
@elasticmachine
Copy link

elasticmachine commented Apr 16, 2024

Package azure_metrics - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@zmoog zmoog

Labels

enhancement New feature or request Integration:azure_metrics Azure Resource Metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zmoog @elasticmachine @vigneshshanmugam @andrewkroh