Allow to override build date with SOURCE_DATE_EPOCH#2202
Merged
extrawurst merged 4 commits intogitui-org:masterfrom May 16, 2024
bmwiedemann:date
Merged
Allow to override build date with SOURCE_DATE_EPOCH#2202extrawurst merged 4 commits intogitui-org:masterfrom bmwiedemann:date
extrawurst merged 4 commits intogitui-org:masterfrom
bmwiedemann:date
Conversation
extrawurst
reviewed
Apr 24, 2024
Collaborator
|
thanks for the contribution, just a very small nitpick, otherwise good to go |
to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This patch was done while working on reproducible builds for openSUSE.
Contributor
Author
|
Are more changes needed? |
Collaborator
|
Can you fix the CI issues? |
Collaborator
|
@bmwiedemann it really is nothing more than running cargo fmt so that it formats the |
Collaborator
|
@bmwiedemann did these changes and merged it, thanks for your contribution |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This patch was done while working on reproducible builds for openSUSE. --------- Co-authored-by: extrawurst <mail@rusticorn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the following:
SOURCE_DATE_EPOCHenv and uses it asbuild_dateI followed the checklist:
make checkwithout errorsAllow to override build date with
SOURCE_DATE_EPOCHto make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This patch was done while working on reproducible builds for openSUSE.