📝 Fix doctrings for max_digits and decimal_places#14944
Open
YuriiMotov wants to merge 1 commit intomasterfrom
Open
📝 Fix doctrings for max_digits and decimal_places#14944YuriiMotov wants to merge 1 commit intomasterfrom
max_digits and decimal_places#14944YuriiMotov wants to merge 1 commit intomasterfrom
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
@Areeb455, this PR hasn't been merged yet. So, to check it you need to checkout to the branch of this PR ( |
alejsdev
approved these changes
Feb 22, 2026
|
Thank you @YuriiMotov! I've reviewed the latest changes in the branch. The docstrings are now technically accurate and the wording is much clearer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are only applicable for
Decimaltype: https://github.com/pydantic/pydantic/blob/8be4a57eb36760c85fa97a3bdea78a1f283489d0/pydantic/_internal/_known_annotated_metadata.py#L44