Skip to content

✏️ Fix client_password typo in OAuth2 form docstrings#14946

Open
bysiber wants to merge 1 commit intofastapi:masterfrom
bysiber:fix/client-password-typo-oauth2
Open

✏️ Fix client_password typo in OAuth2 form docstrings#14946
bysiber wants to merge 1 commit intofastapi:masterfrom
bysiber:fix/client-password-typo-oauth2

Conversation

@bysiber
Copy link

@bysiber bysiber commented Feb 20, 2026

The client_secret parameter docstring in both OAuth2PasswordRequestForm and OAuth2PasswordRequestFormStrict incorrectly referred to client_password instead of client_secret.

The parameter itself is correctly named client_secret, and the rest of each docstring also uses client_secret — it's just this one mention that had the wrong name.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2026

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing bysiber:fix/client-password-typo-oauth2 (2c09b63) with master (faee822)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (c441583) during the generation of this report, so faee822 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@bysiber bysiber force-pushed the fix/client-password-typo-oauth2 branch from f562377 to 2c09b63 Compare February 20, 2026 00:34
@YuriiMotov YuriiMotov added the docs Documentation about how to use FastAPI label Feb 20, 2026
Copy link
Member

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants