check various task states before returning#1739
Merged
Conversation
It's possible that the task was not successful, was canceled or timed out which should be checked before returning. Existing callers of this method catch Exception so new exception types being thrown are safe.
Collaborator
Coverage ReportAffected SDKsNo changes between base commit (b348663) and head commit (b25aa31d). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (b25aa31d) is created by Prow via merging commits: b348663 f28aaa5. |
Collaborator
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (b25aa31d) is created by Prow via merging commits: b348663 f28aaa5. |
mrwillis21
approved these changes
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that the task was not successful, was canceled or timed
out which should be checked before returning. Existing callers of this
method catch Exception so new exception types being thrown are safe.