Make the Crashlytics isEmulator check much more robust.#2515
Merged
Conversation
This is based on Flutter's isEmulator check for Android.
Collaborator
Coverage ReportAffected SDKsNo changes between base commit (352ac58) and head commit (c1ee665d). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (c1ee665d) is created by Prow via merging commits: 352ac58 0239813. |
Collaborator
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (c1ee665d) is created by Prow via merging commits: 352ac58 0239813. |
mrichards
approved these changes
Mar 16, 2021
Contributor
mrichards
left a comment
There was a problem hiding this comment.
Approve. I have a slight concern about a performance hit. All these values are quick lookups?
…e. This should give very good coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the Crashlytics isEmulator check much more robust.
This is based on Flutter's isEmulator check for Android. This should also fix #2495.