fix: disable blame and history popup for untracked files#2489
Merged
extrawurst merged 7 commits intogitui-org:masterfrom Oct 28, 2025
Merged
Conversation
Contributor
Author
|
I have run Hope this is okay. I think it could be addressed in another PR to refactor the cognitive complexity of the |
Contributor
|
I would add |
Contributor
Author
|
I have added |
42254f7 to
97d5e5b
Compare
Collaborator
|
@kpbaks thanks for your contribution. please add a changelog entry and its good to go |
extrawurst
requested changes
Mar 15, 2025
Collaborator
extrawurst
left a comment
There was a problem hiding this comment.
Please add changelog entry matching other changelog entries style
An untracked file does not have any history data. Right now when you press `B` for the blame popup or the `H` for the history popup you get an empty popup where the title spins endlessly trying to find the file in the commit history, and show relevant information. This commit disables the two actions in the `StatusTreeComponent`, when the selected item is a file which is not tracked by git.
fcdba06 to
9b76e4c
Compare
Contributor
Author
|
Added entry to CHANGELOG.md |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
cruessler
pushed a commit
to cruessler/gitui
that referenced
this pull request
Oct 29, 2025
) * fix: disable blame and history popup for untracked files An untracked file does not have any history data. Right now when you press `B` for the blame popup or the `H` for the history popup you get an empty popup where the title spins endlessly trying to find the file in the commit history, and show relevant information. This commit disables the two actions in the `StatusTreeComponent`, when the selected item is a file which is not tracked by git. --------- Co-authored-by: extrawurst <mail@rusticorn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An untracked file does not have any history data. Right now when you press
Bfor the blame popup or theHfor the history popup you get an empty popup where the title spins endlessly trying to find the file in the commit history, and show relevant information. This commitIt changes the following:
StatusTreeComponent, when the selected item is a file which is not tracked by git.I followed the checklist:
make checkwithout errors