This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Conversation
…values from request.
chanseokoh
reviewed
Jan 10, 2022
Contributor
chanseokoh
left a comment
There was a problem hiding this comment.
LGTM, pending minor comments. And do you plan to expand the tests?
gax/src/main/java/com/google/api/gax/rpc/internal/RoutingHeaderHelper.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/internal/RoutingHeaderHelperTest.java
Outdated
Show resolved
Hide resolved
meltsufin
suggested changes
Jan 11, 2022
Member
meltsufin
left a comment
There was a problem hiding this comment.
Please try to include a javadoc comment for each public class and method. We should probably enforce it via the checkstyle.
gax/src/main/java/com/google/api/gax/rpc/internal/RoutingHeaderHelper.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/internal/RoutingHeaderHelperTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/internal/RoutingHeaderHelperTest.java
Outdated
Show resolved
Hide resolved
vam-google
suggested changes
Jan 11, 2022
Contributor
vam-google
left a comment
There was a problem hiding this comment.
All but one comments are minor. Using guava on public surface is forbidden, please change that.
gax/src/main/java/com/google/api/gax/rpc/internal/RoutingHeaderHelper.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/rpc/internal/RoutingHeaderHelper.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/rpc/internal/RoutingHeaderHelper.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/rpc/internal/RoutingHeaderHelper.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/internal/RoutingHeaderHelperTest.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/rpc/internal/RoutingHeaderHelper.java
Outdated
Show resolved
Hide resolved
- Move it up to rpc package - Add java docs. - Rename tests.
meltsufin
approved these changes
Jan 13, 2022
Member
meltsufin
left a comment
There was a problem hiding this comment.
LGTM, pending resolution of comments.
gax-grpc/src/main/java/com/google/api/gax/grpc/RoutingHeaderParamsBuilder.java
Outdated
Show resolved
Hide resolved
gax-grpc/src/main/java/com/google/api/gax/grpc/RoutingHeaderParamsBuilder.java
Outdated
Show resolved
Hide resolved
gax-grpc/src/main/java/com/google/api/gax/grpc/RoutingHeaderParamsBuilder.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jan 19, 2022
gax-grpc/src/test/java/com/google/api/gax/grpc/RoutingHeaderParamsBuilderTest.java
Outdated
Show resolved
Hide resolved
… public create() method for instantiating the builder. Add more Javadoc.
vam-google
approved these changes
Jan 26, 2022
Contributor
vam-google
left a comment
There was a problem hiding this comment.
LGTM, just one comment.
meltsufin
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support explicit dynamic routing headers: googleapis/sdk-platform-java#869, we have to match-and-extract field values from requests during runtime for each configured routing rule parameter, this PR is to add a request params builder to handle the common logics.