Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

chore: Remove @BetaApi annotations for the de-facto GA features#1627

Merged
vam-google merged 2 commits intogoogleapis:mainfrom
vam-google:master
Feb 11, 2022
Merged

chore: Remove @BetaApi annotations for the de-facto GA features#1627
vam-google merged 2 commits intogoogleapis:mainfrom
vam-google:master

Conversation

@vam-google
Copy link
Contributor

@vam-google vam-google commented Feb 10, 2022

Those features have been under BetaApi annotation for 2-3+ years.

They are:

  • Long running operations logic
  • Streaming logic
  • Fields extractor logic
  • Interceptors logic
  • Response metadata logic
  • Custom headers logic

Many of the classes under gax-httpjson module remain BetaApi as those are much younger than grpc and shared classes, and will be cleaned up with httpjson module GA (which whill hopefully happen in H1).

Not all BetaApi annotations were removed. For example channel pool configuration and recent explicit headers logic kept Beta, as those are much newer.

This also addresses a couple old issues: #1095 and #702

Those features have been under `BetaApi` annotation for 2-3+ years.
They are:
- Long running operations logic
- Streaming logic
- Fields extractor logic
- Interceptors logic
- Response metadata logic

Few things were deprecated instead of "de-beta'ed":
- `Pages` class
- `Distribution` class

those classes are a dead code and probably were used by the already-deleted benchmark module.

Many of the classes under gax-httpjson module remain `BetaApi` as those are much younger than grpc and shared classes, and will be cleaned up with httpjson module GA (which whill hopefully happen in H1).

This also addresses a couple old issues: googleapis#1095 and googleapis#702
@vam-google vam-google requested review from a team February 10, 2022 23:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vam-google vam-google merged commit 837a90b into googleapis:main Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants