fix(storage): Avoid integration test segfaults.#12419
fix(storage): Avoid integration test segfaults.#12419BrennaEpp merged 4 commits intogoogleapis:mainfrom
Conversation
If the JWT private key file is not specified in an environment variable, then skip the tests which would otherwise require it. This matches what other tests do. Without this change, `jwt.Email` results in a nil dereference.
|
I think we are inconsistent with the creds we use in the tests - a while back I started documenting this but never quite finished and we've expanded since then. If most other tests work without the env var set, maybe we can instead extract the info we need from the creds set on the client? |
|
Thanks for the integration test instruction pointer! I don't have a project set up like that but I can take a look. I made these all (and the other places where we currently skip when jwt == nil) into test failures. |
BrennaEpp
left a comment
There was a problem hiding this comment.
Looks good, thanks.
We can change it later to extract creds but we def don't want these to "silently" fail
If the JWT private key file is not specified in an environment variable, then skip the tests which would otherwise require it. This matches what other tests do. Without this change,
jwt.Emailresults in a nil dereference.