fix(auditmanager)!: generate correct go proto code#13872
Open
hongalex wants to merge 4 commits intogoogleapis:mainfrom
Open
fix(auditmanager)!: generate correct go proto code#13872hongalex wants to merge 4 commits intogoogleapis:mainfrom
hongalex wants to merge 4 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of incorrectly generated Go proto code for the auditmanager service. By moving the proto files from apiv1main/ to apiv1/ and updating all internal references, imports, and documentation links, the package structure is now consistent with the intended API versioning. This is a breaking change as noted in the PR description, which is appropriate given the correction of the package path. The changes in the binary descriptors within the .pb.go files accurately reflect the new Go package path. The author has been thorough in updating all examples and snippets to ensure consistency across the repository.
shollyman
approved these changes
Feb 20, 2026
shollyman
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change: we are removing the incorrectly generated
apiv1main/*.pb.gofiles and placing them inapiv1/directory instead.