chore(all): update opentelemetry-go-contrib monorepo (main) - abandoned#13876
chore(all): update opentelemetry-go-contrib monorepo (main) - abandoned#13876renovate-bot wants to merge 4 commits intogoogleapis:mainfrom
Conversation
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, most notably opentelemetry-go-contrib. The code change in spanner/test/opentelemetry/test/ot_traces_test.go correctly migrates from a deprecated OpenTelemetry gRPC interceptor to the new stats handler API. However, this change introduces a potential for duplicated trace spans for unary RPCs. I've added a comment asking for clarification on the test's sensitivity to span count, as duplicated spans might not be an issue if the test only asserts existence.
| MinOpened: minOpened, | ||
| }, | ||
| }, option.WithGRPCDialOption(grpc.WithStreamInterceptor(otelgrpc.StreamClientInterceptor(otelgrpc.WithTracerProvider(te.tp))))) | ||
| }, option.WithGRPCDialOption(grpc.WithStatsHandler(otelgrpc.NewClientHandler(otelgrpc.WithTracerProvider(te.tp))))) |
There was a problem hiding this comment.
This change correctly migrates from the deprecated StreamClientInterceptor to NewClientHandler. However, NewClientHandler instruments both unary and streaming calls. A co-existing otelgrpc.UnaryClientInterceptor for this client will lead to duplicated spans for unary calls. Please confirm if this test is sensitive to the total count of spans. If the test only asserts the existence of specific spans and is not sensitive to the total count, then these duplicated spans might not be an issue, and the otelgrpc.UnaryClientInterceptor might not need to be removed.
References
- For OpenTelemetry trace testing, do not filter spans if the test only asserts the existence of specific spans and is not sensitive to the total count.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
v1.38.0→v1.40.0v0.63.0→v0.65.0v0.61.0→v0.65.0v0.61.0→v0.65.0Release Notes
open-telemetry/opentelemetry-go-contrib (go.opentelemetry.io/contrib/detectors/gcp)
v1.40.0: /v2.2.0/v0.65.0/v0.34.0/v0.20.0/v0.15.0/v0.13.0/v0.12.0Compare Source
Overview
Added
WithMetricAttributesFnoption ingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpcto define dynamic attributes on auto-instrumented metrics. (#8191)go.opentelemetry.io/contrib/otelconf. (#8281)const Versioningo.opentelemetry.io/contrib/bridges/prometheus. (#8401)const Versioningo.opentelemetry.io/contrib/otelconf. (#8461)const Versioningo.opentelemetry.io/contrib/bridges/otellogr. (#8477)const Versioningo.opentelemetry.io/contrib/bridges/otellogrus. (#8485)const Versioningo.opentelemetry.io/contrib/bridges/otelslog. (#8480)Fixed
TracerProviderorMeterProvidertoWithTracerProviderorWithMeterProvideringo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (#8323)Transportingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpnow supports reading request body multiple times for subsequent requests that reusehttp.Request. (#8352)Changed
Version()function ingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttphas been replaced byconst Version. (#8142)Version()function ingo.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptracehas been replaced byconst Version. (#8302)Version()function ingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpchas been replaced byconst Version. (#8317)Version()function ingo.opentelemetry.io/contrib/zpageshas been replaced byconst Version. (#8325)Version()function ingo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongohas been replaced byconst Version. (#8340)Version()function ingo.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelginhas been replaced byconst Version. (#8341)Version()function ingo.opentelemetry.io/contrib/instrumentation/runtimehas been replaced byconst Versionstring. (#8349)Version()function ingo.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelawshas been replaced byconst Version. (#8356)Version()function ingo.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambdahas been replaced byconst Version. (#8357)Version()function ingo.opentelemetry.io/contrib/instrumentation/hosthas been replaced byconst Version. (#8358)Version()function ingo.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestfulhas been replaced byconst Version. (#8360)Version()function ingo.opentelemetry.io/contrib/propagators/opencensushas been replaced byconst Version. (#8361)Version()function ingo.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelechohas been replaced byconst Version. (#8365)Version()function ingo.opentelemetry.io/contrib/samplers/probability/consistenthas been replaced byconst Version. (#8366)Version()function ingo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongohas been replaced byconst Version. (#8370)error.typeattribute instead of addingexceptionspan events ingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp. (#8386)error.typeattribute instead of addingexceptionspan events ingo.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws. (#8386)go.opentelemetry.io/otel/semconvtov1.39.0, including updates across all instrumentation and detector modules. (#8404)The semantic conventions v1.39.0 release introduces breaking changes, including:
rpcspan and metric attributes have been renamed to align with naming guidelines:rpc.system→rpc.system.name(values:grpc,grpc_web,connectrpc,thrift,dubbo, etc.)rpc.methodandrpc.servicehave been merged into a fully-qualifiedrpc.methodattributerpc.client|server.duration→rpc.client|server.call.duration(unit changed to seconds)rpc.grpc.request.metadata/rpc.grpc.response.metadata→rpc.request.metadata/rpc.response.metadatarpc.grpc.status_code→ deprecated in favor ofrpc.response.status_coderpc.jsonrpc.request_id→jsonrpc.request.idrpc.jsonrpc.version→jsonrpc.protocol.versionsystemandprocessmetrics:*.linux.memorymetrics renamed to*.memory.linuxsystem.process.status→process.statesystem.paging.typeandprocess.paging.fault_type→system.paging.fault.typepeer.serviceattribute has been deprecated in favor ofservice.peer.nameSee semantic-conventions v1.39.0 release and v1.38.0 release for complete breaking change details.
Updated modules include:
go.opentelemetry.io/contrib/bridges/otellogrgo.opentelemetry.io/contrib/bridges/otellogrusgo.opentelemetry.io/contrib/bridges/otelsloggo.opentelemetry.io/contrib/bridges/otelzapgo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpservice.peer.nameattribute (deprecatedpeer.service)go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptracego.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpcrpc.methodandrpc.serviceinto fully-qualifiedrpc.method(e.g.,grpc.testing.TestService/EmptyCall)rpc.system→rpc.system.namewith updated values (e.g.,RPCSystemNameGRPC)rpc.grpc.status_code→rpc.response.status_code(e.g.,RPCResponseStatusCode("OK"))go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelawsrpc.methodandrpc.serviceattributes (service/operation → fully-qualified method)rpc.system→rpc.system.namewithAWSSystemValMethodAttr()function for combined service/operation attributego.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambdago.opentelemetry.io/contrib/instrumentation/runtimego.opentelemetry.io/contrib/instrumentation/hostgo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver(both v1 and v2)go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgingo.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestfulgo.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelechogo.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmuxgo.opentelemetry.io/contrib/detectors/gcpgo.opentelemetry.io/contrib/detectors/aws/ec2/v2go.opentelemetry.io/contrib/detectors/aws/ecsgo.opentelemetry.io/contrib/detectors/aws/eksgo.opentelemetry.io/contrib/detectors/azure/azurevmgo.opentelemetry.io/contrib/otelconfDeprecated
ServiceAttr()function ingo.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelawsis deprecated. UseMethodAttr()instead, asrpc.servicehas been merged intorpc.methodin semantic conventions v1.39.0. (#8404)OperationAttr()function ingo.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelawsis deprecated. UseMethodAttr()instead, asrpc.servicehas been merged intorpc.methodin semantic conventions v1.39.0. (#8404)Removed
DefaultClient,Get,Head,Post, andPostFormingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp. Use a custom*http.Clientwithotelhttp.NewTransport(http.DefaultTransport)instead. (#8266)WithPublicEndpointingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp. UseWithPublicEndpointFninstead. (#8267)WithRouteTagingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp. The route is already added automatically for spans. For metrics, the alternative is to use theWithMetricAttributesFnoption. (#8268)What's Changed
8475f28by @renovate[bot] in #8273otelhttpClientby @MrAlias in #82668475f28by @renovate[bot] in #8274b6eea26by @renovate[bot] in #8279WithPublicEndpointfromotelhttpby @MrAlias in #8267WithRouteTagoption inotelhttpby @MrAlias in #826897cd9d5by @renovate[bot] in #8292e75fd47by @renovate[bot] in #82967004b74by @renovate[bot] in #830498d557bby @renovate[bot] in #8305e0dd3ddby @renovate[bot] in #8318944ab1fby @renovate[bot] in #8319718f0e5by @renovate[bot] in #83240a764e5by @renovate[bot] in #83323f2a21fby @renovate[bot] in #83310fe9cd7by @renovate[bot] in #8351914a6e7by @renovate[bot] in #8371bd525daby @renovate[bot] in #837999fd39fby @renovate[bot] in #8389716be56by @renovate[bot] in #83963f89685by @renovate[bot] in #8397c6413dcby @renovate[bot] in #8412b8f7ae3by @renovate[bot] in #84398e98ce8by @renovate[bot] in #8458d11affdby @renovate[bot] in #8465a19766bby @renovate[bot] in #846758372ceby @renovate[bot] in #84668636f87by @renovate[bot] in #8468fcf36f6by @renovate[bot] in #847173d1f95by @renovate[bot] in #8475semconvtov1.39.0by @MrAlias in #8481New Contributors
Full Changelog: open-telemetry/opentelemetry-go-contrib@v1.39.0...v1.40.0
v1.39.0: /v2.1.0/v0.64.0/v0.33.0/v0.19.0/v0.14.0/v0.12.0/v0.11.0Compare Source
Overview
Added
ParseYAMLingo.opentelemetry.io/contrib/otelconfnow supports environment variables substitution in the format${[env:]VAR_NAME[:-defaultvalue]}. (#6215)http.routemetric attribute togo.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux. (#7966)db.client.operation.durationmetric forgo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo. (#7983)WithSpanNameFormatteroption togo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo. (#7986)Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.