Skip to content

DLP: avoid replacing/scribbling on 'setup.py' during synth.#6125

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:dlp-synth-ignore_setup.py
Sep 28, 2018
Merged

DLP: avoid replacing/scribbling on 'setup.py' during synth.#6125
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:dlp-synth-ignore_setup.py

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 27, 2018

Closes #6123.

@tseaver tseaver added api: dlp Issues related to the Sensitive Data Protection API. codegen labels Sep 27, 2018
@tseaver tseaver requested a review from crwilcox September 27, 2018 17:59
@tseaver tseaver requested a review from theacodes as a code owner September 27, 2018 17:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2018
@tseaver tseaver changed the title Avoid replacing/scribbling on 'setup.py' during synth. DLP: avoid replacing/scribbling on 'setup.py' during synth. Sep 27, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Sep 28, 2018

This seems obviously correct -- we aren't relying on upstream changes to set version numbers, etc. here.

@tseaver tseaver merged commit b2b8463 into googleapis:master Sep 28, 2018
@tseaver tseaver deleted the dlp-synth-ignore_setup.py branch September 28, 2018 16:25
parthea pushed a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dlp Issues related to the Sensitive Data Protection API. cla: yes This human has signed the Contributor License Agreement. codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants