Skip to content

Don't mask auth errors in to_dataframe with BQ Storage API#7674

Merged
tswast merged 3 commits intogoogleapis:masterfrom
tswast:issue7661-bqstorage-auth
Apr 8, 2019
Merged

Don't mask auth errors in to_dataframe with BQ Storage API#7674
tswast merged 3 commits intogoogleapis:masterfrom
tswast:issue7661-bqstorage-auth

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Apr 5, 2019

Don't hide errors such as insufficient permissions to create
a read session, or the API is not enabled. Both of those are
clearly problems if the developer has explicitly asked for
BigQuery Storage API support.

Closes #7661.

Don't hide errors such as insufficient permissions to create
a read session, or the API is not enabled. Both of those are
clearly problems if the developer has explicitly asked for
BigQuery Storage API support.
@tswast tswast added the api: bigquerystorage Issues related to the BigQuery Storage API. label Apr 5, 2019
@tswast tswast requested a review from shollyman April 5, 2019 23:29
@tswast tswast requested a review from crwilcox as a code owner April 5, 2019 23:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2019
@tswast tswast changed the title Don't mask auth errors in to_dataframe with BQ Storage API Don't mask auth errors in to_dataframe with BQ Storage API Apr 5, 2019
@tswast
Copy link
Contributor Author

tswast commented Apr 8, 2019

pytype failure in API Core seems unrelated to this change.

@tswast tswast requested review from alixhami and steffnay April 8, 2019 20:27
@tswast tswast merged commit a3b9b75 into googleapis:master Apr 8, 2019
@tswast tswast deleted the issue7661-bqstorage-auth branch April 8, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the BigQuery Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants