BigQuery: Mock external calls in one of BigQuery unit tests#8727
Merged
tswast merged 1 commit intogoogleapis:masterfrom Jul 22, 2019
Merged
BigQuery: Mock external calls in one of BigQuery unit tests#8727tswast merged 1 commit intogoogleapis:masterfrom
tswast merged 1 commit intogoogleapis:masterfrom
Conversation
Contributor
Author
|
FWIW, one of the unrelated BigQuery unit tests will probably still fail, which is addressed in the scope of #8713. |
tswast
approved these changes
Jul 22, 2019
Contributor
|
I merged #8713. We should update sync this with master to be safe before merging. |
tseaver
approved these changes
Jul 22, 2019
Contributor
Author
|
Rebased on top of the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8719
This PR properly mocks external calls in one of the tests.
How to test
$ unset GOOGLE_APPLICATION_CREDENTIALStest_bigquery_magic_w_maximum_bytes_billed_invalid.Actual result (before the fix):
The test fails with
DefaultCredentialsError.Expected result (after the fix):
The code under tests raises
ValueErroras expected, and the test passes.