Storage: Fix documentation misleading response_type signed_url#8942
Merged
tseaver merged 4 commits intogoogleapis:masterfrom Aug 7, 2019
Merged
Conversation
tseaver
suggested changes
Aug 6, 2019
| :type response_type: str | ||
| :param response_type: (Optional) Content type of responses to requests for | ||
| the signed URL. Ignored if content_type is set. | ||
| the signed URL. Ignored if content_type is set on object/blob metadata. |
Contributor
There was a problem hiding this comment.
Please wrap to the next line here (and the other similar docstrings).
| projection=projection, | ||
| fields=fields, | ||
| client=self | ||
| client=self, |
Contributor
There was a problem hiding this comment.
Please rebase against the head of master, which already has this change (and the others below) from PR #8831.
e0e059c to
68db71a
Compare
tseaver
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7696