Skip to content

BigQuery: Change default endpoint to bigquery.googleapis.com #9213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 2 commits into from
Sep 13, 2019
Merged

BigQuery: Change default endpoint to bigquery.googleapis.com #9213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
703d02f
Change default URL to bigquery.googleapis.com.
busunkim96 Sep 11, 2019
a29f9ec
Update endpoint in more locations.
busunkim96 Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigquery/google/cloud/bigquery/_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Connection(_http.JSONConnection):
:param client_info: (Optional) instance used to generate user agent.
"""

DEFAULT_API_ENDPOINT = "https://www.googleapis.com"
DEFAULT_API_ENDPOINT = "https://bigquery.googleapis.com"

def __init__(self, client, client_info=None, api_endpoint=DEFAULT_API_ENDPOINT):
super(Connection, self).__init__(client, client_info)
Expand Down
2 changes: 1 addition & 1 deletion bigquery/google/cloud/bigquery/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
_MAX_MULTIPART_SIZE = 5 * 1024 * 1024
_DEFAULT_NUM_RETRIES = 6
_BASE_UPLOAD_TEMPLATE = (
u"https://www.googleapis.com/upload/bigquery/v2/projects/"
u"https://bigquery.googleapis.com/upload/bigquery/v2/projects/"
u"{project}/jobs?uploadType="
)
_MULTIPART_URL_TEMPLATE = _BASE_UPLOAD_TEMPLATE + u"multipart"
Expand Down
4 changes: 2 additions & 2 deletions bigquery/tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3127,7 +3127,7 @@ def _initiate_resumable_upload_helper(self, num_retries=None):
# Check the returned values.
self.assertIsInstance(upload, ResumableUpload)
upload_url = (
"https://www.googleapis.com/upload/bigquery/v2/projects/"
"https://bigquery.googleapis.com/upload/bigquery/v2/projects/"
+ self.PROJECT
+ "/jobs?uploadType=resumable"
)
Expand Down Expand Up @@ -3196,7 +3196,7 @@ def _do_multipart_upload_success_helper(self, get_boundary, num_retries=None):
get_boundary.assert_called_once_with()

upload_url = (
"https://www.googleapis.com/upload/bigquery/v2/projects/"
"https://bigquery.googleapis.com/upload/bigquery/v2/projects/"
+ self.PROJECT
+ "/jobs?uploadType=multipart"
)
Expand Down
4 changes: 2 additions & 2 deletions bigquery/tests/unit/test_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def _make_job_resource(
started=False,
ended=False,
etag="abc-def-hjk",
endpoint="https://www.googleapis.com",
endpoint="https://bigquery.googleapis.com",
job_type="load",
job_id="a-random-id",
project_id="some-project",
Expand Down Expand Up @@ -1022,7 +1022,7 @@ class _Base(object):
from google.cloud.bigquery.dataset import DatasetReference
from google.cloud.bigquery.table import TableReference

ENDPOINT = "https://www.googleapis.com"
ENDPOINT = "https://bigquery.googleapis.com"
PROJECT = "project"
SOURCE1 = "http://example.com/source1.csv"
DS_ID = "dataset_id"
Expand Down