Storage: Move benchwrapper directory into 'tests/perf/'.#9246
Merged
tseaver merged 4 commits intogoogleapis:masterfrom Sep 18, 2019
tseaver:storage-move-benchwrapper
Merged
Storage: Move benchwrapper directory into 'tests/perf/'.#9246tseaver merged 4 commits intogoogleapis:masterfrom tseaver:storage-move-benchwrapper
tseaver merged 4 commits intogoogleapis:masterfrom
tseaver:storage-move-benchwrapper
Conversation
jeanbza
reviewed
Sep 18, 2019
Contributor
jeanbza
left a comment
There was a problem hiding this comment.
This is fine with me, but do we have quorum on this location? Each time we move it I have to update configs, so I'd love to pic one canonical spot and copy it everywhere. :)
jeanbza
reviewed
Sep 18, 2019
Contributor
Author
|
@jadekler Moving those files puts them in a normal / expected location (e.g., so that lint / black run), and eases command-line completion (no conflict between |
jeanbza
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jadekler Moving to keep the root directory with just 'tests'.