fix: make google-http-client.properties file shading friendly#1046
fix: make google-http-client.properties file shading friendly#1046chingor13 merged 1 commit intogoogleapis:masterfrom medb:patch-2
Conversation
|
@medb Can you describe why this change is needed? The properties file should be able to be loaded from an uber-jar or other shaded jar just fine without modification. I have a local project on my machine I used to execute a few commands against Firestore (which is a downstream consumer of this library). This project is packaged as a "jar-with-dependencies" file. From this code public static void main(String[] args) {
System.out.println("HttpRequest.VERSION = " + com.google.api.client.http.HttpRequest.VERSION);
} |
|
@BenWhitehead The issue is that if there are 2 versions of this library in a class path - 1) shaded/relocated library of Because both of these libraries will load non-shaded |
|
@chingor13 What are you thoughts here on moving the properties file? We might need to move it for the couple other libraries we introduced this same pattern in. |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.37.0](https://www.github.com/googleapis/google-http-java-client/compare/v1.36.0...v1.37.0) (2020-10-13) ### Features * add flag to allow UrlEncodedContent to use UriPath escaping ([#1100](https://www.github.com/googleapis/google-http-java-client/issues/1100)) ([9ab7016](https://www.github.com/googleapis/google-http-java-client/commit/9ab7016032327f6fb0f91970dfbd511b029dd949)), closes [#1098](https://www.github.com/googleapis/google-http-java-client/issues/1098) ### Bug Fixes * make google-http-client.properties file shading friendly ([#1046](https://www.github.com/googleapis/google-http-java-client/issues/1046)) ([860bb05](https://www.github.com/googleapis/google-http-java-client/commit/860bb0541bcd7fc516cad14dd0d52481c7c7b414)) ### Dependencies * update protobuf-java to 3.13.0 ([#1093](https://www.github.com/googleapis/google-http-java-client/issues/1093)) ([b7e9663](https://www.github.com/googleapis/google-http-java-client/commit/b7e96632234e944e0e476dedfc822333716756bb)) ### Documentation * libraries-bom 12.0.0 ([#1136](https://www.github.com/googleapis/google-http-java-client/issues/1136)) ([450fcb2](https://www.github.com/googleapis/google-http-java-client/commit/450fcb2293cf3fa7c788cf0cc8ae48e865ae8de8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
…operties - Make it file shading friendly like googleapis/google-http-java-client#1046 - Avoid set proguard config to read this file. b/279795343#comment2
Fixes an issue when there are 2 versions of this library in a class path - 1) shaded/relocated library of
x.x.xversion inside a "jar-with-dependencies" and 2) non-shaded library ofy.y.yversion.Because both of these libraries will load non-shaded
google-http-client.propertiesfile they will use the samey.y.yversion even though shaded library has ax.x.xversion.