Skip to content

chore: Fix short query tests#4125

Open
lqiu96 wants to merge 3 commits intomainfrom
short-query
Open

chore: Fix short query tests#4125
lqiu96 wants to merge 3 commits intomainfrom
short-query

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Mar 2, 2026

Fixes: #4105 and #4106

@lqiu96 lqiu96 requested a review from jinseopkim0 March 2, 2026 16:08
@lqiu96 lqiu96 requested review from a team as code owners March 2, 2026 16:08
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Mar 2, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 2, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues where short BigQuery queries, expected to be stateless, might still result in a job being created, leading to inconsistent JobId and QueryId behavior in TableResult. It introduces a JobCreationReason enum to provide explicit context for why a job was created, enhancing the clarity and debuggability of query execution. The changes also update relevant integration tests to correctly validate this new behavior and ensure robust handling of query results.

Highlights

  • New Enum for Job Creation Reason: Introduced a new JobCreationReason enum to categorize why a BigQuery job was created, providing explicit context for query execution.
  • Integration of Job Creation Reason: Integrated the JobCreationReason into TableResult and BigQueryImpl to store and retrieve the reason for job creation when processing query responses.
  • Updated Query Integration Tests: Modified integration tests (ITBigQueryTest) to accurately assert the JobCreationReason and the relationship between JobId and QueryId for short queries, addressing previous inconsistencies.
  • OpenTelemetry SDK Initialization Fix: Corrected the OpenTelemetry SDK initialization in integration tests by changing buildAndRegisterGlobal() to build().
Changelog
  • google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
    • Added logic to set JobCreationReason when building TableResult from query responses.
  • google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobCreationReason.java
    • Added a new enum JobCreationReason to represent why a BigQuery job was created.
  • google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java
    • Added JobCreationReason field and its builder/getter methods.
  • google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
    • Updated assertions for testTableResultJobIdAndQueryId and testQueryWithTimeout to check JobCreationReason and JobId/QueryId consistency.
    • Changed OpenTelemetry SDK initialization to build() instead of buildAndRegisterGlobal().
Activity
  • No specific activity (comments, reviews, progress) has been provided for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 2, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces the JobCreationReason enum and integrates it into the BigQueryImpl and TableResult classes. This enhancement allows for better tracking of why a BigQuery job was created, especially in scenarios involving JOB_CREATION_OPTIONAL mode. The integration appears sound, and the updated integration tests (ITBigQueryTest.java) correctly reflect and validate the new functionality, including handling cases where simple queries might still result in job creation with an OTHER reason. The changes are well-contained and address the linked issues effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinseopkim0 jinseopkim0 Awaiting requested review from jinseopkim0

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigquery.it.ITNightlyBigQueryTest: testTableResultJobIdAndQueryId failed

1 participant

@lqiu96