This repository was archived by the owner on Sep 16, 2023. It is now read-only.
Conversation
Shabirmean
suggested changes
Feb 7, 2022
Contributor
Shabirmean
left a comment
There was a problem hiding this comment.
Some minor comments and suggestions. Is there a way we can test? Are we creating clusters in the JDST project and re-triggering the CI on this PR?
google-cloud-container/src/test/java/com/google/cloud/container/v1/it/Util.java
Show resolved
Hide resolved
google-cloud-container/src/test/java/com/google/cloud/container/v1/it/Util.java
Outdated
Show resolved
Hide resolved
google-cloud-container/src/test/java/com/google/cloud/container/v1/it/Util.java
Show resolved
Hide resolved
Neenu1995
approved these changes
Feb 7, 2022
Contributor
|
LGTM. But address Shabir's comments before merging. |
Shabirmean
approved these changes
Feb 11, 2022
Contributor
Shabirmean
left a comment
There was a problem hiding this comment.
LGTM!
I see that the latest commits haven't still updated the code based on the comments. Maybe leave a feedback if you choose to not change them
added 2 commits
February 11, 2022 10:15
Contributor
Author
It seems owlbot overwrote the changes I made regarding the |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In this PR https://github.com/googleapis/java-container/issues/656 we saw that the quota for our clusters hit a max since tests were not cleaning up after themselves. Per Neenu's suggestion, we added a cleanup to the
beforeAllto ensure that old clusters are deleted