Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

fix: change the default node image to cos_containerd#706

Merged
Shabirmean merged 1 commit intomainfrom
fix-imagemismatch
Mar 23, 2022
Merged

fix: change the default node image to cos_containerd#706
Shabirmean merged 1 commit intomainfrom
fix-imagemismatch

Conversation

@Shabirmean
Copy link
Contributor

@Shabirmean Shabirmean commented Mar 23, 2022 •
edited
Loading

Fixes #705

Description

  • Integration tests were failing on the nightly builds for the repo
  • The issue was that docker was phased out as the default container runtime for GKE in 1.19.
  • Thus, it was recommended to use the node image (cos_containerd) which is specific to containerd runtime and to move away from the current node image cos
  • In the most recent release of GKE the default node image used is cos_containerd
  • Because of this the integration test that checks for this was failing.
  • See release notes for information.

image

Changes

  • Fixed the above issue by changing the check to COS_CONTAINERD (the new node image) from COS

@Shabirmean Shabirmean requested review from a team, Neenu1995 and NimJay March 23, 2022 15:54
@Shabirmean Shabirmean added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@Shabirmean Shabirmean added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 23, 2022
NimJay
NimJay approved these changes Mar 23, 2022
View reviewed changes
Copy link

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for taking care if this so fast, Shabir!

@product-auto-label product-auto-label bot added the api: container Issues related to the googleapis/java-container API. label Mar 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@Shabirmean Shabirmean closed this Mar 23, 2022
@Shabirmean Shabirmean reopened this Mar 23, 2022
@Shabirmean Shabirmean merged commit 9ffa70d into main Mar 23, 2022
@Shabirmean Shabirmean deleted the fix-imagemismatch branch March 23, 2022 19:21
@release-please release-please bot mentioned this pull request Mar 23, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 30, 2022
@release-please
chore(main): release 2.3.6 (#707)
aa24209 
🤖 I have created a release *beep* *boop*
---


### [2.3.6](v2.3.5...v2.3.6) (2022-03-29)


### Bug Fixes

* change the default node image to cos_containerd ([#706](#706)) ([9ffa70d](9ffa70d))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([#709](#709)) ([bb64318](bb64318))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

2 more reviewers

@NimJay NimJay NimJay approved these changes

@xtineskim xtineskim xtineskim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: container Issues related to the googleapis/java-container API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

container.v1.it.ITSystemTest: getServerConfigTest failed

4 participants

@Shabirmean @NimJay @xtineskim @yoshi-kokoro