fix: Prevent excessive string parsing when publishing and receiving messages to improve performance#2317
Merged
michaelpri10 merged 11 commits intogoogleapis:mainfrom Feb 27, 2025
Merged
Conversation
…essages to improve performance
|
Thanks for taking this up. I believe |
hongalex
reviewed
Jan 25, 2025
| private final Distribution ackLatencyDistribution; | ||
|
|
||
| private final String subscriptionName; | ||
| private final SubscriptionName subscriptionNameObject; |
Member
There was a problem hiding this comment.
How does this new object interact with the previous subscriptionName string? Is the latter still necessary?
Contributor
Author
There was a problem hiding this comment.
The old String subscriptionName is actually no longer used, so I've removed it. subscriptionNameObject is created in the constructor using the string that is passed in to the builder, but that string is not needed after.
Contributor
Author
|
@hongalex Gentle bump on this. |
Contributor
Author
|
@hongalex Friendly bump on this PR. |
lahuang4
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2295 ☕️
Based off of PR #2304, which some added changes to the subscribe path.