fix(perf regression): TopicName parsing per publish#2304
Closed
MV-GH wants to merge 1 commit intogoogleapis:mainfrom
Closed
fix(perf regression): TopicName parsing per publish#2304MV-GH wants to merge 1 commit intogoogleapis:mainfrom
MV-GH wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Hello @MV-GH! Thank you so much for the contribution and great catch on this performance issue! This is a change that we will also be making in the Subscriber client, so I will put out a separate pull request with all of the changes together and close this once that is merged. |
Contributor
|
/gcbrun |
Contributor
|
This change was merged in #2317, so I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2295
i believe this was introduced in db522b6
With the same reproducer as in the issue. From testing it seems to improve throughput by 10%
Profile before
producer_load_test_v1.zip
Profile after
producer_load_test_after_optimization_v1.zip
Note: I believe there is a similar problem in
OpenTelemetryPubsubTracer.startPublishRpcSpan. But I kept the scope of this PR to a minimum.