fix: catch ExecutionException for op.getName#1729
Merged
rajatbhatta merged 1 commit intomainfrom Mar 5, 2022
Merged
Conversation
olavloite
reviewed
Mar 5, 2022
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/slow/ITBackupTest.java
Outdated
Show resolved
Hide resolved
olavloite
approved these changes
Mar 5, 2022
Following exception is thrown: java.util.concurrent.ExecutionException: com.google.api.gax.rpc.FailedPreconditionException: io.grpc.StatusRuntimeException: FAILED_PRECONDITION. So, changing the catch to catch ExecutionException as well. Catch both SpannerException and ExecutionException. Co-authored-by: Knut Olav Løite <koloite@gmail.com>
e017ad9 to
e226252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following exception is thrown:
java.util.concurrent.ExecutionException: com.google.api.gax.rpc.FailedPreconditionException: io.grpc.StatusRuntimeException: FAILED_PRECONDITION.
So, changing the catch in order to catch all appropriate exceptions.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1652 ☕️
If you write sample code, please follow the samples format.