feat: changes to support data, timestamp and arrays in IT tests#1840
Merged
asthamohta merged 8 commits intogoogleapis:mainfrom Jul 5, 2022
Merged
feat: changes to support data, timestamp and arrays in IT tests#1840asthamohta merged 8 commits intogoogleapis:mainfrom
asthamohta merged 8 commits intogoogleapis:mainfrom
Conversation
olavloite
approved these changes
Apr 22, 2022
Collaborator
olavloite
left a comment
There was a problem hiding this comment.
Looks good to me, with a couple of minor questions.
| Struct row = | ||
| execute( | ||
| Statement.newBuilder("SELECT @v").bind("v").toNumericArray(asList(b1, b2, null)), | ||
| Statement.newBuilder(selectValueQuery).bind("p1").toNumericArray(asList(b1, b2, null)), |
Collaborator
There was a problem hiding this comment.
This test case seem to be disabled for PostgreSQL still. Is that intentional?
The same also seems to be the case for other numeric array tests.
Contributor
Author
There was a problem hiding this comment.
missed those, adding it
| } | ||
|
|
||
| @Test | ||
| public void testReadNullValuesInArraysPostgreSQL() { |
Collaborator
There was a problem hiding this comment.
Why do we need separate tests for GoogleSQL and PostgreSQL in this case? They seem to be equal. Or am I missing something?
Contributor
Author
There was a problem hiding this comment.
structs and json are not supported and column names are different as PG requires explicit quotes for case
| Assume.assumeTrue(dialect.dialect == Dialect.POSTGRESQL); | ||
| try (ResultSet resultSet = | ||
| databaseClient.singleUse().executeQuery(Statement.of("SELECT 10.0 AS float64"))) { | ||
| databaseClient |
Collaborator
There was a problem hiding this comment.
Why does this need a separate test case?
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
🤖 I have created a release *beep* *boop* --- ## [6.26.0](v6.25.7...v6.26.0) (2022-07-13) ### Features * Adding two new fields for Instance create_time and update_time ([#1908](#1908)) ([00b3817](00b3817)) * changes to support data, timestamp and arrays in IT tests ([#1840](#1840)) ([c667653](c667653)) * Error Details Improvement ([c8a2184](c8a2184)) * Error Details Improvement ([#1929](#1929)) ([c8a2184](c8a2184)) ### Bug Fixes * enable longpaths support for windows test ([#1485](#1485)) ([#1946](#1946)) ([fd0b845](fd0b845)) ### Dependencies * update dependency com.google.cloud:google-cloud-trace to v2.3.0 ([#1934](#1934)) ([2813eb2](2813eb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.