ci: using JDK 11+ to compile and JDK 8 to run junit (8) by suztomo · Pull Request #1870 · googleapis/java-spanner

suztomo · 2022-05-05T02:22:34Z

Upgrading JDK setting to compile the code in Java 11 and run the tests in Java 8.

For "junit (8)" GitHub Actions, the compilation is done in JDK 11 (targeting Java 8 runtime) and test execution is on JDK 8.
For release, the compilation is done in JDK 11 (targeting Java 8 runtime).

Background: this helps to let the latest GraalVM-related code inside this repository while keeping the support of Java 8. GraalVM 21.1.0 (latest) started Java8-incompatible bytecode.

TODO: discuss this idea with Spanner team (and schedule appropriate time slot that avoids important milestones). -> The milestone has been done.

generated-files-bot · 2022-05-05T02:22:39Z

Warning: This pull request is touching the following templated files:

.github/workflows/ci.yaml
.kokoro/release/common.cfg

suztomo · 2022-05-05T13:37:52Z

pom.xml

+    <profile>
+      <!-- JDK 9+ has the "release" option to ensure the generated bytecode is
+       compatible with Java 8. -->
+      <id>compiler-release-8</id>


This profile may be appropriate to be defined in the google-cloud-shared-config (the parent pom of this file).

The google-cloud-shared-config defines compiler option:

<source>1.8</source> <target>1.8</target>

https://github.com/googleapis/java-shared-config/blob/3f84da04d9df8d0a114915e8faa8dc2e682e7cb5/pom.xml#L175

Added todo: googleapis/java-shared-config#477

suztomo · 2022-05-05T13:42:41Z

We may need to address windows build but that's feasible.

ansh0l

@rajatbhatta : Please check this PR for nightly tests.

We seem to be switching to java11 from java8 at a couple of places, so we need to ensure existing builds around java8 are working allright.

ansh0l · 2022-05-24T08:42:34Z

.github/workflows/ci.yaml

      fail-fast: false
      matrix:
-        java: [8, 11, 17]
+        java: [11, 17]


Will this impact any of the existing test runs against java8? units-java8 job should cover the unit tests, but on fusion, I can see java8-samples as another job.

cc @thiagotnunes

For Kokoro builds, I have modified java8 container to have JAVA11_HOME environment variable in googleapis/testing-infra-docker#211.

suztomo@suztomo:~$ docker run --rm -it --entrypoint bash gcr.io/cloud-devrel-kokoro-resources/java8 Unable to find image 'gcr.io/cloud-devrel-kokoro-resources/java8:latest' locally latest: Pulling from cloud-devrel-kokoro-resources/java8 ... Digest: sha256:86a9e70f109b5efd16204dea51cf30aa2295bbbd4e980d2fd2172d2f7b2382e4 Status: Downloaded newer image for gcr.io/cloud-devrel-kokoro-resources/java8:latest root@c4a6f4994f6c:/workspace# root@c4a6f4994f6c:/workspace# printenv PYENV_SHELL=bash HOSTNAME=c4a6f4994f6c JAVA_HOME=/usr/local/openjdk-8 JAVA8_HOME=/usr/local/openjdk-8 ... JAVA11_HOME=/usr/lib/jvm/java-11-openjdk-amd64 ...

@suztomo We specify the docker image version for java8-samples here: https://github.com/googleapis/java-spanner/blob/main/.kokoro/nightly/java8-samples.cfg#L6

I think this will be alright, but double checking if we set the correct ENV variables in this container as well?

@thiagotnunes Thank you for the info. Yes, that line value: "gcr.io/cloud-devrel-kokoro-resources/java8" matches the container image URL I have modified. It has JAVA8_HOME and JAVA11_HOME now. (I added the docker command invocation to my comment above)

Thanks for the info LGTM

ansh0l · 2022-05-24T08:45:05Z

.kokoro/build.sh

 case ${JOB_TYPE} in
 test)
-    mvn test -B \
+    mvn test -B -V \


What do we need the version of mvn for - does it tie to native image compilation in some way?

This clarifies which versions of JDK it's running. We're running JDK 11 to compile and JDK 8 to run tests. (It's nice-to-have)

suztomo · 2022-05-24T21:36:26Z

.kokoro/build.sh

+if [ ! -z "${JAVA11_HOME}" ]; then
+  setJava "${JAVA11_HOME}"


JAVA11_HOME is now available in the container image for Kokoro:

#1870 (comment)

suztomo · 2022-05-24T21:36:35Z

.kokoro/build.sh

+if [ ! -z "${JAVA8_HOME}" ]; then
+  setJava "${JAVA8_HOME}"


JAVA8_HOME is now available in the container image for Kokoro:

#1870 (comment)

ansh0l

lgtm

suztomo · 2022-05-25T14:13:42Z

My ad-hoc invocation of the Java 8 job http://sponge2/132d68b4-9667-43b0-9d7c-49a2b3f12571 shows good. The "Build Log" tab shows that first it compiled the project with JDK 11:

Java version: 11.0.15, vendor: Debian, runtime: /usr/lib/jvm/java-11-openjdk-amd64

and then it ran tests with JDK 8:

Java version: 1.8.0_332, vendor: Oracle Corporation, runtime: /usr/local/openjdk-8/jre

suztomo requested review from a team May 5, 2022 02:22

product-auto-label bot added the size: m Pull request size is medium. label May 5, 2022

product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label May 5, 2022

suztomo marked this pull request as draft May 5, 2022 02:24

suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 5, 2022

ci: using JDK 11 to compile and JDK 8 to run junit (8)

ba89167

suztomo force-pushed the java8-and-java11 branch from 4c05bcc to ba89167 Compare May 5, 2022 02:30

ci: release build to use JDK 11

a18055c

suztomo changed the title ~~ci: using JDK 11 to compile and JDK 8 to run junit (8)~~ ci: using JDK 11+ to compile and JDK 8 to run junit (8) May 5, 2022

suztomo commented May 5, 2022

View reviewed changes

mpeddada1 mentioned this pull request May 20, 2022

fix: add native image configurations for Spanner classes #1858

Merged

suztomo added 3 commits May 20, 2022 10:40

Merge remote-tracking branch 'origin/main' into java8-and-java11

37f7eb2

build: configuring owlbot.py to exclusion

100f41e

ci: windows build for JDK 11 and 8

e42a572

suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2022

suztomo added 2 commits May 20, 2022 11:10

investigating windows environment variables

ac77054

shell: bash for windows

52a1214

suztomo marked this pull request as ready for review May 20, 2022 15:18

removed debug output

ec67faf

suztomo added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. labels May 20, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2022

mpeddada1 approved these changes May 23, 2022

View reviewed changes

suztomo mentioned this pull request May 23, 2022

deps: adding JDK 11 as the supplement to java8 container googleapis/testing-infra-docker#211

Merged

suztomo requested a review from ansh0l May 23, 2022 20:46

ansh0l suggested changes May 24, 2022

View reviewed changes

ansh0l requested review from rajatbhatta and thiagotnunes May 24, 2022 15:06

suztomo commented May 24, 2022

View reviewed changes

thiagotnunes approved these changes May 24, 2022

View reviewed changes

ansh0l approved these changes May 25, 2022

View reviewed changes

suztomo merged commit 4143583 into googleapis:main May 25, 2022

suztomo mentioned this pull request Aug 30, 2024

ci: simplify java 8 unit tests googleapis/java-firestore#1804

Merged

mpeddada1 mentioned this pull request May 28, 2025

chore: replace AlloyDBFeature with static JSON config GoogleCloudPlatform/alloydb-java-connector#645

Merged

Conversation

suztomo commented May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

generated-files-bot bot commented May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo commented May 5, 2022

Uh oh!

ansh0l left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ansh0l left a comment

Choose a reason for hiding this comment

Uh oh!

suztomo commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

suztomo commented May 5, 2022 •

edited

Loading

generated-files-bot bot commented May 5, 2022 •

edited

Loading

suztomo May 5, 2022 •

edited

Loading

suztomo May 24, 2022 •

edited

Loading

suztomo May 24, 2022 •

edited

Loading

suztomo commented May 25, 2022 •

edited

Loading