Skip to content

sample: add support for Directed Read options#2394

Merged
harshachinta merged 11 commits intogoogleapis:mainfrom
rajatbhatta:directed-reads-sample
Jan 19, 2024
Merged

sample: add support for Directed Read options#2394
harshachinta merged 11 commits intogoogleapis:mainfrom
rajatbhatta:directed-reads-sample

Conversation

@rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Apr 20, 2023 •
edited by harshachinta
Loading

This PR adds samples for Directed Reads.
The implementation for Directed Reads is in #2766

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Apr 20, 2023
@rajatbhatta rajatbhatta marked this pull request as ready for review April 21, 2023 10:20
@rajatbhatta rajatbhatta requested a review from a team April 21, 2023 10:20
@snippet-bot
Copy link

snippet-bot bot commented Apr 21, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

olavloite
olavloite reviewed Apr 24, 2023
View reviewed changes
@rajatbhatta @olavloite
fix nit
8b3fadd 
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2024
@rajatbhatta rajatbhatta requested a review from a team January 18, 2024 16:58
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
olavloite
olavloite approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions for additional comments.

@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@harshachinta harshachinta merged commit 6b9513f into googleapis:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

@arpan14 arpan14 Awaiting requested review from arpan14

@asthamohta asthamohta Awaiting requested review from asthamohta

+1 more reviewer

@harshachinta harshachinta harshachinta left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kweinmeister kweinmeister

Labels

api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajatbhatta @olavloite @harshachinta @kweinmeister