test: refactor executor code with autogenerated protos#2759
Merged
harshachinta merged 5 commits intogoogleapis:mainfrom Dec 20, 2023
Merged
test: refactor executor code with autogenerated protos#2759harshachinta merged 5 commits intogoogleapis:mainfrom
harshachinta merged 5 commits intogoogleapis:mainfrom
Conversation
arpan14
reviewed
Dec 19, 2023
...ud-spanner-executor/src/main/java/com/google/cloud/spanner/executor/CloudClientExecutor.java
Outdated
Show resolved
Hide resolved
This reverts commit 28a9022.
This reverts commit a1218a3.
arpan14
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The executor framework in Java depends on the proto from artifact uploaded through cndb-client-testing-protos repo.
Recently we have added OwlBot setup in #2754 to auto generate the protos similar to other spanner folders. #2756 is the result of this owlbot configuration where the protos for executor now lie with in this repo and gets updated automatically through owl-bot.
This PR replaces the references of earlier protos with the newly generated protos. The validation of this change has been performed on local systest which runs successfully.
https://screenshot.googleplex.com/B4dn7jKBi8Z6muM